Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test #154

Closed
wants to merge 3 commits into from
Closed

Fix test #154

wants to merge 3 commits into from

Conversation

xuyuon
Copy link
Contributor

@xuyuon xuyuon commented Sep 11, 2024 •
edited
Loading

I am just moving changes in the tests from #133 to here. Fixed a few tests:

  • Fixed test_sine() and test_cosine() in test_prior.py
  • The test script for IMRPhenomPv2 should use IMRPhenomPv2 as waveform, instead of IMRPhenomD
  • Fixed boundToUnbound transform for the luminosity distance in the integration test

* The tests test_GW150914_D_heterodyne.py and test_GW150914_D.py are failing under the new jim version

@xuyuon xuyuon mentioned this pull request Sep 16, 2024
Closed
@kazewong kazewong closed this Oct 16, 2024
@xuyuon xuyuon deleted the fix-test branch November 5, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuyuon @kazewong