Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Run Manager #135

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Conversation

thomasckng
Copy link
Collaborator

Run manager works with the new framework now

@thomasckng
Copy link
Collaborator Author

We can add other features later on

@thomasckng thomasckng self-assigned this Aug 21, 2024
Copy link
Collaborator

@ThibeauWouters ThibeauWouters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I checked the tests and example and found no errors. Indeed there are places where we might want to improve how the runmanager handles things, but we'll leave that to future work. It's good to have an up-to-date runmanager first.

@ThibeauWouters ThibeauWouters merged commit 15a103d into kazewong:run-manager Aug 22, 2024
2 of 4 checks passed
@thomasckng thomasckng deleted the run-manager branch August 28, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants