Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated jim output #122

Conversation

xuyuon
Copy link
Contributor

@xuyuon xuyuon commented Aug 2, 2024

  • Fixed Jim.print_summary()
  • Fixed Jim.get_samples()
  • Added SpinToCartesianSpinTransform() to allow transformation from ["theta_jn", "phi_jl", "theta_1", "theta_2", "phi_12", "a_1", "a_2"] to ["iota", "s1_x", "s1_y", "s1_z", "s2_x", "s2_y", "s2_z"]
  • Added a test script test_GW150914_pv2.py, which runs on IMRPhenomPV2 waveform to test the class SpinToCartesianSpinTransform().
  • All unit tests passed

Copy link
Collaborator

@thomasckng thomasckng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@kazewong kazewong merged commit 87440db into kazewong:98-moving-naming-tracking-into-jim-class-from-prior-class Aug 2, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants