-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mass & sky position transform #118
Merged
kazewong
merged 41 commits into
kazewong:98-moving-naming-tracking-into-jim-class-from-prior-class
from
thomasckng:transform
Aug 2, 2024
Merged
Add mass & sky position transform #118
kazewong
merged 41 commits into
kazewong:98-moving-naming-tracking-into-jim-class-from-prior-class
from
thomasckng:transform
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-class-from-prior-class Sync
…ss' into transform
…ss' into transform
…ss' into transform
…ss' into transform
…ss' into transform
…ss' into transform
kazewong
reviewed
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments and restructuring before merging
src/jimgw/transforms.py
Outdated
from beartype import beartype as typechecker | ||
from jaxtyping import Float, Array, jaxtyped | ||
from astropy.time import Time | ||
|
||
from jimgw.single_event.detector import GroundBased2G |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comment in the same file below
kazewong
approved these changes
Aug 2, 2024
kazewong
merged commit Aug 2, 2024
9d9c833
into
kazewong:98-moving-naming-tracking-into-jim-class-from-prior-class
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.