Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mass & sky position transform #118

Conversation

thomasckng
Copy link
Collaborator

No description provided.

@thomasckng thomasckng changed the title Transform Add mass transform Jul 31, 2024
@thomasckng thomasckng changed the title Add mass transform Add mass & sky position transform Aug 1, 2024
@kazewong kazewong self-requested a review August 2, 2024 14:56
Copy link
Owner

@kazewong kazewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments and restructuring before merging

src/jimgw/single_event/utils.py Outdated Show resolved Hide resolved
src/jimgw/transforms.py Outdated Show resolved Hide resolved
from beartype import beartype as typechecker
from jaxtyping import Float, Array, jaxtyped
from astropy.time import Time

from jimgw.single_event.detector import GroundBased2G
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment in the same file below

@kazewong kazewong merged commit 9d9c833 into kazewong:98-moving-naming-tracking-into-jim-class-from-prior-class Aug 2, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants