expires => undef means that expires is not specified.
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c88febd breaks a test of [Ark](https://github.com/ark-framework/ark). ref. ark-framework/ark#10
|
Thank you. Original Cookie::Baker broke compatibility. I merge this p-r. |
kazeburo
added a commit
that referenced
this pull request
Jun 29, 2015
`expires => undef` means that expires is not specified.
|
Thank you for merging! |
kazeburo
added a commit
that referenced
this pull request
Jun 29, 2015
Changelog diff is:
diff --git a/Changes b/Changes
index 54d9fe3..6c3eeb3 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,10 @@ Revision history for Perl extension Cookie-Baker
{{$NEXT}}
+0.06 2015-06-29T05:53:57Z
+
+ - fix compatibility issue. #4 (Thank you shogo82148)
+
0.05 2014-11-26T05:49:50Z
- fix bug. accepts expires => 0
kazeburo
added a commit
that referenced
this pull request
Sep 21, 2016
Changelog diff is:
diff --git a/Changes b/Changes
index 6c3eeb3..280b02a 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,10 @@ Revision history for Perl extension Cookie-Baker
{{$NEXT}}
+0.07 2016-09-21T01:35:56Z
+
+ - Allow quoted cookie values, as per RFC 6265. #8
+
0.06 2015-06-29T05:53:57Z
- fix compatibility issue. #4 (Thank you shogo82148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c88febd breaks a test of Ark.
ref. ark-framework/ark#10
I think Cookie::Baker should accept
expires => undefbecause of compatibility.How do you think?