Add support of SAMPLE ClickHouse clause #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YiuRULE
force-pushed
the
gt/clickhouse_sample
branch
from
f782143
to
443eb54
Compare
|
Could you pull from the master branch so that the newest CI test kick in? |
ns-gtassery
force-pushed
the
gt/clickhouse_sample
branch
3 times, most recently
from
115c4c1
to
e8c2c5d
Compare
|
done, it has been rebase to master |
AzisK
reviewed
Oct 4, 2023
pypika/dialects.py
Outdated
| @@ -781,6 +781,16 @@ def drop_view(self, view: str) -> "ClickHouseDropQueryBuilder": | |||
| class ClickHouseQueryBuilder(QueryBuilder): | |||
| QUERY_CLS = ClickHouseQuery | |||
|
|
|||
| def __init__(self, **kwargs) -> None: | |||
| super().__init__(self, as_keyword=True) | |||
There was a problem hiding this comment.
is there no need to send other kwargs to the super().__init__?
There was a problem hiding this comment.
I think my previous code was indeed wrong, it has been corrected on the latest revision, thanks for bringing up the issue
ns-gtassery
force-pushed
the
gt/clickhouse_sample
branch
from
e8c2c5d
to
7801d05
Compare
AzisK
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.