Skip to content

Commit

Permalink
Revert base Parameter constructor back to it's original signature
Browse files Browse the repository at this point in the history
  • Loading branch information
mvanderlee committed Feb 22, 2024
1 parent 352b38b commit 66c6310
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions pypika/terms.py
Original file line number Diff line number Diff line change
Expand Up @@ -299,15 +299,12 @@ def named_placeholder_gen(idx: int) -> str:
class Parameter(Term):
is_aggregate = None

def __init__(self, placeholder: Union[str, int, Callable[[int], str]] = idx_placeholder_gen) -> None:
def __init__(self, placeholder: Union[str, int]) -> None:
super().__init__()
self._placeholder = placeholder

@property
def placeholder(self):
if callable(self._placeholder):
return self._placeholder(None)

return self._placeholder

def get_sql(self, **kwargs: Any) -> str:
Expand All @@ -322,8 +319,7 @@ def get_param_key(self, placeholder: Any, **kwargs):

class ListParameter(Parameter):
def __init__(self, placeholder: Union[str, int, Callable[[int], str]] = idx_placeholder_gen) -> None:
super().__init__()
self._placeholder = placeholder
super().__init__(placeholder=placeholder)
self._parameters = list()

@property
Expand All @@ -342,8 +338,7 @@ def update_parameters(self, value: Any, **kwargs):

class DictParameter(Parameter):
def __init__(self, placeholder: Union[str, int, Callable[[int], str]] = named_placeholder_gen) -> None:
super().__init__()
self._placeholder = placeholder
super().__init__(placeholder=placeholder)
self._parameters = dict()

@property
Expand Down

0 comments on commit 66c6310

Please sign in to comment.