Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pr yml #6

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Fix pr yml #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8392def
fix: fix PR.yml
kaszabimre Oct 4, 2024
2295eb8
chore: update README.md
kaszabimre Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/PR.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
uses: actions/checkout@v4

- name: Set up JDK
uses: actions/setup-java
uses: actions/setup-java@v3.13.0
with:
distribution: corretto
java-version: 18
Expand All @@ -41,7 +41,7 @@ jobs:
uses: actions/checkout@v4

- name: Set up JDK
uses: actions/setup-java
uses: actions/setup-java@v3.13.0
with:
distribution: corretto
java-version: 18
Expand All @@ -57,7 +57,7 @@ jobs:
uses: actions/checkout@v4

- name: Set up JDK
uses: actions/setup-java
uses: actions/setup-java@v3.13.0
with:
distribution: corretto
java-version: 18
Expand All @@ -76,7 +76,9 @@ jobs:
rm -f iosApp.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
xcodebuild -resolvePackageDependencies -project iosApp.xcodeproj
xcodebuild build-for-testing \
-scheme "EAPlayers" \
-scheme "iosApp" \
-project iosApp.xcodeproj \
-destination 'platform=iOS Simulator,name=iPhone 14,OS=16.4' \
-allowProvisioningUpdates
-destination 'platform=iOS Simulator,name=iPhone 15,OS=17.2' \
-allowProvisioningUpdates \
-configuration Debug \
DEVELOPMENT_TEAM=${{ secrets.APPLE_TEAM_ID }} # Reference the GitHub secret here
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

EAPlayers is a Kotlin Multiplatform project that leverages **Compose Multiplatform** for both Android and iOS to provide a fully native mobile app experience. The project uses [EA's Drop API](https://drop-api.ea.com) to fetch player information.

![GitHub Actions build status](https://github.com/kaszabimre/EAPlayers/actions/workflows/PR.yml/badge.svg)

![iOS](https://img.shields.io/badge/iOS-000000?style=for-the-badge&logo=ios&logoColor=white)
![Android](https://img.shields.io/badge/Android-3DDC84?style=for-the-badge&logo=android&logoColor=white)
![Kotlin](https://img.shields.io/badge/Kotlin-0095D5?&style=for-the-badge&logo=kotlin&logoColor=white)
Expand Down
Loading