Update Kanister dependancy and API fixes #320
Conversation
Signed-off-by: Prasad Ghangal <[email protected]>
Signed-off-by: Prasad Ghangal <[email protected]>
Signed-off-by: Prasad Ghangal <[email protected]>
PrasadG193
force-pushed
the
update-kanister-dep
branch
from
28f410b to
7e6e465
Compare
| pvc, err := o.kubeCli.CoreV1().PersistentVolumeClaims(namespace).Get(ctx, pvcName, metav1.GetOptions{}) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return pvc, nil |
There was a problem hiding this comment.
Fake clients (in k8s 1.31 client-go sdk) no longer returns nil object in case of error. So we had to add explicit checks
There was a problem hiding this comment.
hmm shouldn't the caller be checking if error is nil before checking the value anyway? Or does this result in a lot of changes to UTs? Why can't we just return the objects as is?
There was a problem hiding this comment.
Alternatively, we'll have to refactor tests, instead of checking for nil, we'll have to check for empty structs. My intention was to have consistent values in the return. E.g in case of other types of error in the same function, we are returning nil, but in K8s API error, it returns empty struct. We'll also have to refactor UT accordingly to check for different value in case of different types of errors.
PrasadG193
changed the title
Signed-off-by: Prasad Ghangal <[email protected]>
This PR upgrades Kanister dependancy to
0abc731c8242a5af8682e46607f429563683da8eand fixes breaking APIs after depemdancy upgrade. With Kanister dep, the K8s dep also gets ugpraded to1.31which requires some refactor in the return statements. The fake K8s client no longer returns nil object in case of error, so the additional check for error is added.