Skip to content

Commit

Permalink
reducing examples to less than 5s #26
Browse files Browse the repository at this point in the history
  • Loading branch information
kassambara committed Feb 18, 2023
1 parent ec54581 commit 6542243
Show file tree
Hide file tree
Showing 21 changed files with 53 additions and 71 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Package: fastqcr
Type: Package
Title: Quality Control of Sequencing Data
Version: 0.1.3
Date: 2023-02-17
Date: 2023-02-18
Authors@R: c(
person("Alboukadel", "Kassambara", role = c("aut", "cre"), email = "[email protected]")
)
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Using `select()` in place of the deprecated `select_()` function in `qc_aggregate()` and `qc_problems()` (#24)
- Using `arrange()` and `group_by()` in place of the deprecated `arrange_()` and `group_by()_` functions in `qc_problems()`
- Changing http to https for urls concerning fastc installation and documentation
- `qc_read_collection()` and `qc_plot_collection()` examples reduced to less than 5 seconds

## Bug fixes

Expand Down
20 changes: 11 additions & 9 deletions R/qc_plot_collection.R
Original file line number Diff line number Diff line change
Expand Up @@ -28,26 +28,28 @@ NULL
#' @examples
# extract paths to the demo files
#' qc.dir <- system.file("fastqc_results", package = "fastqcr")
#' qc.files <- list.files(qc.dir, full.names = TRUE)[1:3]
#' qc.files <- list.files(qc.dir, full.names = TRUE)[1:2]
#' nb_samples <- length(qc.files)
#'
#' # read all modules in all files
#' qc <- qc_read_collection(qc.files, sample_names = paste('S', 1:nb_samples, sep = ''))
#' # read specific modules in all files
#' # To read all modules, specify: modules = "all"
#' modules <- c(
#' "Per sequence GC content",
#' "Per base sequence quality",
#' "Per sequence quality scores"
#' )
#' qc <- qc_read_collection(qc.files, sample_names = paste('S', 1:nb_samples, sep = ''),
#' modules = modules)
#'
#' # Plot per sequence GC content
#' qc_plot_collection(qc, "Per sequence GC content")
#'
#' # Per base sequence quality
#' qc_plot_collection(qc, "Per base sequence quality")
#'
#'
#' # Per sequence quality scores
#' qc_plot_collection(qc, "Per sequence quality scores")
#'
#' # Per base sequence content
#' qc_plot_collection(qc, "Per base sequence content")
#'
#' # Sequence duplication levels
#' qc_plot_collection(qc, "Sequence duplication levels")
#'
#' @export
qc_plot_collection <- function(qc, modules = "all"){
Expand Down
6 changes: 2 additions & 4 deletions R/qc_read_collection.R
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,12 @@
#' @examples
#' # extract paths to the demo files
#' qc.dir <- system.file("fastqc_results", package = "fastqcr")
#' qc.files <- list.files(qc.dir, full.names = TRUE)[1:3]
#' qc.files <- list.files(qc.dir, full.names = TRUE)[1:2]
#' nb_samples <- length(qc.files)
#'
#' # read all modules in all files
#' qc <- qc_read_collection(qc.files, sample_names = paste('S', 1:nb_samples, sep = ''))
#'
#'
#' # read a specified module in all files
#' # To read all modules, specify: modules = "all"
#' qc <- qc_read_collection(qc.files,
#' sample_names = paste('S', 1:nb_samples, sep = ''),
#' modules = "Per base sequence quality")
Expand Down
4 changes: 2 additions & 2 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ There were no ERRORs, WARNINGs or NOTES.
## Downstream dependencies
There are currently no downstream dependencies for this package

## Update
## Resubmission

This is a new version fastqcr 0.1.3 (see NEWS.md)
This is a resubmission of version fastqcr 0.1.3 (see NEWS.md). In this version all examples were reduced to less than 5 seconds to fix CRAN auto-check NOTES
2 changes: 1 addition & 1 deletion docs/pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ pandoc: 2.7.3
pkgdown: 2.0.7
pkgdown_sha: ~
articles: {}
last_built: 2023-02-17T07:09Z
last_built: 2023-02-18T06:08Z

Binary file modified docs/reference/Rplot002.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/Rplot003.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/Rplot004.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/Rplot005.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion docs/reference/qc_aggregate.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/reference/qc_plot.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified docs/reference/qc_plot_collection-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/qc_plot_collection-2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/qc_plot_collection-3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
31 changes: 12 additions & 19 deletions docs/reference/qc_plot_collection.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/qc_problems.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions docs/reference/qc_read.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 6542243

Please sign in to comment.