Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chribjel
reviewed
Nov 5, 2024
Comment on lines
+41
to
+59
| export function getClientId() { | ||
| return config.clientId; | ||
| } | ||
|
|
||
| export function getAuthority() { | ||
| return config.authority; | ||
| } | ||
|
|
||
| export function getRedirectUri() { | ||
| return config.redirect_uri; | ||
| } | ||
|
|
||
| export function getBackendUrl() { | ||
| return config.backend_url; | ||
| } | ||
|
|
||
| export function getregelrettFrontendUrl() { | ||
| return config.regelrett_frontend_url; | ||
| } |
There was a problem hiding this comment.
dette trenger vel ikke være funksjoner, men kan bare exporteres som const
There was a problem hiding this comment.
Kan ikke assigne const før dataen er hentet tror jeg :/
chribjel
reviewed
Nov 5, 2024
|
Hvorfor kan vi ikke ha en .env fil for hvert miljø? |
|
To årsaker:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beskrivelse
🥅 Mål med PRen:
Vi begynner å få veldig mange kjøremiljøer for appen (localhost, gcp, skip-dev, skip-prod). Kan ikke ha en .env-fil for hvert eneste kjøremiljø. Ønsker en mer dynamisk approach som kan både gjøre det smud å deploye til nye miljøer, men også gjør det fortsatt enkelt å sette opp og utvikle lokalt.
Løsning
Henter ut config rett fra kjøremiljøet til nginx (som må settes i skip/gcp/fly eller hvor enn du kjører nginx fra)
🆕 Endring:
🧪 Testing
Sjekk at appen fungerer som før. Jeg er ikke helt sikker på om alt er som det skal.
Mulig det kan gjøres på en annen måte i frontend (bruk av React context for eksempel).