Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Markdown class configurable (see #17) #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

drenty
Copy link
Contributor

@drenty drenty commented Apr 18, 2014

See #17

My suggestion to make Markdown class extendable and configurable so we can override beforeProcess and afterProcess.

Not ready to merge (no doc). RFC only.

Can be configured like this:

'modules' => [
    'markdown' => [
        'class' => 'kartik\markdown\Module',
        'previewAction' => '/markdown/parse/preview',
        'smartyPants' => true,
        'components' => [
            'parser' => [
                'class' => 'kartik\markdown\Markdown'
            ]
        ]
    ]
]

@drenty
Copy link
Contributor Author

drenty commented Apr 18, 2014

Great! I think this structure will be helpful with cebe's parser too.

@drenty
Copy link
Contributor Author

drenty commented Nov 6, 2014

Hello Kartik,

Do you plan on implementing cebe/markdown?

Do you need a hand?

@kartik-v
Copy link
Owner

kartik-v commented Nov 6, 2014

I am waiting for MarkdownExtra to be fully supported in cebe's parser.

However, it sure would be good if you could lend a hand. One way to do it could be to make this class in a way, where we could configure to use michelf/MarkdownExtra and michelf/SmartyPants based on a property.... and for the rest use cebe's parser.

@drenty
Copy link
Contributor Author

drenty commented Nov 6, 2014

Ok, I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants