Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new flag introduced: it forces prompt context that is sent to backend, be more explicit #329

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vibrys
Copy link

@vibrys vibrys commented Jun 18, 2024

@karthink, thank you very much for the great gptel package. It's great value is noticeable.

I'm issuing PR to prevent users from accidental sending too many data during requesting from org mode buffer.

The idea is to force both branching and topic be present on the path. If they both are included, then one may assume the user set these two intentionally thus sends that part of buffer (s)he wants.

the setting by default is nil (nothing changes to existing users), but IMO it may be considered to be set to true as default.

please let me know what you think about the change.

kind regards,
Vibrys

@vibrys
Copy link
Author

vibrys commented Jun 19, 2024

maybe the idea of explicit context should be spread to other major modes as well.
If yes, then if the gptel-org-force-branching-context-with-topic flag is true, then:

  1. for org-mode the behavior is just as in this pull request
  2. for other modes it's enough that some region is marked.

if this is good idea, then gptel-org-force-branching-context-with-topic should be renamed, for example to: gptel-force-context ?

regards,
Vibrys

it replaces less generic flag (ie org-mode specific): gptel-org-force-branching-context-with-topic
@vibrys vibrys changed the title gptel-org-force-branching-context-with-topic introduced new flag introduced: it forces prompt context that is sent to backend, be more explicit Jun 19, 2024
@vibrys
Copy link
Author

vibrys commented Jun 19, 2024

I've just made the setting more generic, just as described in the message above. Flag name: gptel-force-prompt-context-be-explicit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant