Allow node filtering via URL Hash #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way it should be done, I think, is having an option to tick, “[] Show master nodes, [] Show data nodes”, etc. The real problem is that I have to find enough time to pick up Paramedic after long time, upgrade it to latest Ember, and make the code a bit more sane :) |
|
Heh it's usually like that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had weird issues when I tried to add a filter text field so I implemented it via a hash. The use case for us was we use have client nodes on our app servers and all the client node stats are just clutter.
We'd access it with
index.html#master:truefor example.I'm not really a JS dev and have zero experience with Ember so this is what I managed to hack up in a few minutes.