Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version #165

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hicom150
Copy link
Collaborator

@hicom150 hicom150 commented Jan 5, 2019

  • Update dependencies.
  • Fixed some ESLint errors.
  • Replace libxml-xsd with libxmljs [1]
  • Add support for all nodejs lts versions (6, 8, 10)

[1] libxml-xsd is obsolete and it doesn't support nodejs 10 in the other hand, libxmljs can be used to check xsd schemas.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot
Copy link

CLAs look good, thanks!

@hicom150 hicom150 mentioned this pull request Jan 5, 2019
@johnjbarton
Copy link
Contributor

I think putting each of these in a separate PR will make maintenance easier. We typically merge all the commits in a PR. If any one of these needs to be reverted we'll have to revert them all.

That said I'll leave it to joeyparrish to decide.

It does not look like Travis is connected for this repo.

@hicom150
Copy link
Collaborator Author

hicom150 commented Jan 13, 2019

As @johnjbarton suggested I've divided this in separate PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants