Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xmlbuilder to version 9.0.0 🚀 #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

greenkeeperio-bot
Copy link
Contributor

🚨🔥⚠️ Action required: Switch to the new Greenkeeper now! 🚨🔥⚠️
This version of Greenkeper will be shutdown on May 31st.
With Integrations first-class bot support landed on GitHub and we’ve rewritten Greenkeeper to take full advantage of it. Simpler setup, fewer pull-requests, faster than ever.


Hello lovely humans,

xmlbuilder just published its new version 9.0.0.

State Update 🚀
Dependency xmlbuilder
New version 9.0.0
Type dependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of xmlbuilder.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


The new version differs by 12 commits .

  • 03856cf 9.0.0
  • 6407fb2 Added change log for v9.0.0
  • 15d4f1a Remove node 4.0 and 5.0 from Travis CI
  • 37731d9 Added tests for invalid chars
  • b7da010 Removed text case options. This isn't the job of this library.
  • 1f9b41a Follow XML 1.1 spec for valid chars instead of 1.0. Fixes #147
  • 605aeb3 Added link to examples in the wiki. Fixes #143.
  • 1da59e1 Merge pull request #145 from btsimonh/master
  • 97192a0 Add tests for -ve options.offset and options.dontprettytextnodes
  • 391b638 move setting og @newlinedefault and @prettydefault to constructor and otpions set to fix bug.
  • 3f86e19 introduce a new option 'dontprettytextnodes' which when active, will suppress indent and LF for nodes which contain any text (and all child nodes).
  • 2bc90b6 Allow negetive 'offset' < -1 to be used

See the full diff.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants