Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Permit overriding name, build, and project on a per-browser basis. #91

Merged
merged 1 commit into from
Jan 14, 2017
Merged

Permit overriding name, build, and project on a per-browser basis. #91

merged 1 commit into from
Jan 14, 2017

Conversation

krotscheck
Copy link
Contributor

@krotscheck krotscheck commented Jan 10, 2017

Browserstack uses the name property in the browser configuration
to uniquely name sessions within a specific build. If these sessions
do not have a unique name, and are executed sequentially (or with a
concurrency < total # of browsers), browserstack's UI will overwrite
previous results with new ones. In cases where a karma test run is
executed on multiple browsers, this isn't really desirable.

While I was at it, I also incorporated changes from #71, and
updated the README to also include documentation for that change. With
this patch, name, project, and build, may all be overridden on
a per browser basis.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link

CLAs look good, thanks!

@krotscheck krotscheck changed the title Permit setting the name property per browser configuration. Permit overriding name, build, and project on a per-browser basis. Jan 10, 2017
Browserstack uses the `name` property in the browser configuration
to uniquely name sessions within a specific build. If these sessions
do not have a unique name, and are executed sequentially (or with a
concurrency < total # of browsers), browserstack's UI will overwrite
previous results with new ones. In cases where a karma test run is
executed on multiple browsers, this isn't really desirable.

While I was at it, I also incorporated changes from
#71, and
updated the README to also include documentation for that change. With
this patch, `name`, `project`, and `build`, may all be overridden on
a per browser basis.
@krotscheck
Copy link
Contributor Author

A note on the dependency update - it turns out that grunt-auto-release changed its grunt version requirement in 0.0.7, breaking peerDependencies in the project. For my patch to pass, I had to update the version to 0.0.6 (the last version that required grunt@~0.4).

@dignifiedquire
Copy link
Member

Thanks :octocat:

@dignifiedquire dignifiedquire merged commit 9c77a96 into karma-runner:master Jan 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants