Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix some code examples #35

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

purarue
Copy link
Contributor

@purarue purarue commented Nov 24, 2023

No description provided.

@purarue
Copy link
Contributor Author

purarue commented Nov 24, 2023

noticed an error and thought I would just copy paste the examples into a nvim buffer and let my lsp correct all the others

@purarue
Copy link
Contributor Author

purarue commented Nov 25, 2023

seems to be mismatch between click types and default due to str-casting:

src/bleanser/core/main.py: note: In function "main":
src/bleanser/core/main.py:39:20:39:36: error: Non-overlapping
identity check (left operand type: "Path", right operand type:
"str")  [comparison-overlap]
                assert path2 is _DEFAULT, path2
                       ^~~~~~~~~~~~~~~~~
src/bleanser/core/main.py:47:20:47:40: error: Non-overlapping
identity check (left operand type: "Path", right operand type:
"str")  [comparison-overlap]
                assert path2 is not _DEFAULT
                       ^~~~~~~~~~~~~~~~~~~~~
Found 2 errors in 1 file (checked 56 source files)

could cast(Path, path2), or do something else, not sure

@karlicoss
Copy link
Owner

yeah, cast would be fine, thanks!

@karlicoss
Copy link
Owner

huh, interesting, 3.12 macos fails with some unrelated sqlite issue (wonder if the cli output format changed maybe?) -- I'll take a look

@purarue
Copy link
Contributor Author

purarue commented Nov 28, 2023

Yeah I only glanced at it, I thought it might be a issue with ordering so was going to try sorting the results

@karlicoss
Copy link
Owner

Turned out needed and extra pragma for writable sqlite_master on some sqlite versions, should be fixed in master #36

@karlicoss karlicoss merged commit c71ffb2 into karlicoss:master Dec 2, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants