Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openai api key not being saved #218

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

PassiveModding
Copy link
Contributor

#210

Previously the openai api key would never be saved since it's value was being retrieved from the client.ApiKey property each draw

oops

@Theletha
Copy link

when will this fix be implemented?

@johnysandels
Copy link
Collaborator

It may be awhile, the dev @karashiiro hasn't updated anything recently so I assume they're busy with life stuff.

@karashiiro
Copy link
Owner

I was getting things working for 7.0, then doing MSQ, then Universalis being down took a week of my attention, and now I'm on vacation until Tuesday - I'm planning to catch up on TTT issues once I'm back.

@Theletha
Copy link

i See! Have a good vacation !

@andrewgxp
Copy link

andrewgxp commented Aug 14, 2024

I built the plugin using the new changes proposed in the PR and was able to save my login key!

For some reason, it won't let me copy and paste the API key into the text box. Maybe OpenAI keys are too large for it? I've not been able to get it to functionally work because of that, but I can confirm that it looks to now save whatever I'm putting in!

@xianthe
Copy link

xianthe commented Aug 15, 2024

I built the plugin using the new changes proposed in the PR and was able to save my login key!

For some reason, it won't let me copy and paste the API key into the text box. Maybe OpenAI keys are too large for it? I've not been able to get it to functionally work because of that, but I can confirm that it looks to now save whatever I'm putting in!

Definitely please find out a way to copy the API key.

@xianthe
Copy link

xianthe commented Aug 19, 2024

I did some checking - it seems the API key has a character limit for cut and paste that is not large enough for the 132-character OpenAI key.

@karashiiro
Copy link
Owner

Merging, will fix the length limit myself.

@karashiiro karashiiro merged commit 8477c05 into karashiiro:main Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants