forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Cloud Security] Improve graph component performance (elastic#204983)
## Summary Apply some graph optimizations and added the first graph benchmark storybook. You can read the detailed investigation process [here](elastic#204982 (comment)). I kept the dashed lines until a new design will be introduced. Before: https://github.com/user-attachments/assets/145a82c0-dbd0-410f-a451-eaa8adcc931b After: https://github.com/user-attachments/assets/3c13cae5-85d2-481b-8fc6-cec08ecee0d9 **How to test this PR** To test this PR you can run ``` yarn storybook cloud_security_posture_packages ``` Or open the storybook link attached to the build message ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- Loading branch information
Showing
14 changed files
with
10,834 additions
and
169 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
...ions/security/packages/kbn-cloud-security-posture/graph/src/components/graph/constants.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
/** | ||
* Whether or not to instruct the graph component to only render nodes and edges that would be visible in the viewport. | ||
*/ | ||
export const ONLY_RENDER_VISIBLE_ELEMENTS = true as const; |
83 changes: 83 additions & 0 deletions
83
...security/packages/kbn-cloud-security-posture/graph/src/components/graph/fps_trendline.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import React, { useEffect, useRef, useState } from 'react'; | ||
import { CommonProps } from '@elastic/eui'; | ||
|
||
export const FpsTrendline: React.FC<CommonProps> = (props: CommonProps) => { | ||
const [fpsSamples, setFpsSamples] = useState<number[]>([]); | ||
const frameCount = useRef(0); | ||
const lastTimestamp = useRef(performance.now()); | ||
|
||
useEffect(() => { | ||
let animationFrameId: number; | ||
|
||
const calculateFPS = (timestamp: number) => { | ||
frameCount.current += 1; | ||
const delta = timestamp - lastTimestamp.current; | ||
|
||
if (delta >= 1000) { | ||
const fps = (frameCount.current * 1000) / delta; | ||
setFpsSamples((prevSamples) => { | ||
const updatedSamples = [...prevSamples, fps]; | ||
return updatedSamples.slice(-20); | ||
}); | ||
frameCount.current = 0; | ||
lastTimestamp.current = timestamp; | ||
} | ||
|
||
animationFrameId = requestAnimationFrame(calculateFPS); | ||
}; | ||
|
||
animationFrameId = requestAnimationFrame(calculateFPS); | ||
|
||
return () => cancelAnimationFrame(animationFrameId); | ||
}, []); | ||
|
||
const getBarColor = (fps: number): string => { | ||
if (fps >= 50) return '#4caf50'; // Green | ||
if (fps >= 30) return '#ffeb3b'; // Yellow | ||
return '#f44336'; // Red | ||
}; | ||
|
||
return ( | ||
<div {...props}> | ||
<strong>{'FPS:'}</strong> {Math.round(fpsSamples[fpsSamples.length - 1])} <br /> | ||
<div | ||
css={{ | ||
display: 'flex', | ||
alignItems: 'flex-end', | ||
height: '30px', | ||
padding: '5px', | ||
}} | ||
> | ||
{fpsSamples.map((fps, index) => ( | ||
<div | ||
key={index} | ||
css={{ | ||
height: `${Math.min(fps, 60) * (100 / 60)}%`, | ||
width: '5%', | ||
backgroundColor: getBarColor(fps), | ||
marginRight: '2px', | ||
}} | ||
title={`${fps.toFixed(2)} FPS`} | ||
> | ||
<div | ||
css={{ | ||
fontSize: '8px', | ||
padding: '2px', | ||
left: `${index * 5 + 5}%`, | ||
}} | ||
> | ||
{fps.toFixed(0)} | ||
</div> | ||
</div> | ||
))} | ||
</div> | ||
</div> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.