Skip to content

Commit

Permalink
[UA] More descriptive backup your data text (elastic#204529)
Browse files Browse the repository at this point in the history
## Summary

Close elastic/kibana-team#1359

### Notes

Did not update links as, per the issue request, the "Create snapshot"
button already links to either the snapshots page on Cloud or the
Snapshot & Restore on prem.

### On prem

* Slight tweak to wording
* Made link open in a new tab

<img width="1099" alt="Screenshot 2024-12-16 at 14 04 58"
src="https://github.com/user-attachments/assets/46486e30-42e5-4ba1-bd90-4ba3454d5093"
/>


### Cloud
* Added always visible descriptive paragraph

#### Success

<img width="1264" alt="Screenshot 2024-12-16 at 14 00 26"
src="https://github.com/user-attachments/assets/fa855def-257c-4ed0-a17c-b71bcb99bd76"
/>

#### Error

<img width="566" alt="Screenshot 2024-12-16 at 13 57 53"
src="https://github.com/user-attachments/assets/b65b8d8e-887a-4523-b566-e951381d46cd"
/>

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

---------

Co-authored-by: kibanamachine <[email protected]>
  • Loading branch information
jloleysens and kibanamachine authored Dec 17, 2024
1 parent a229d7a commit 5b68294
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,16 @@ export const CloudBackup: React.FunctionComponent<Props> = ({

return (
<>
<EuiText>
<p>
{i18n.translate('xpack.upgradeAssistant.overview.cloudBackup.description', {
defaultMessage: 'Back up your data using snapshots before proceeding.',
})}
</p>
</EuiText>
<EuiSpacer size="m" />
{statusMessage}
<EuiSpacer size="s" />
<EuiSpacer size="m" />
{/* eslint-disable-next-line @elastic/eui/href-or-on-click */}
<EuiButton
href={cloudSnapshotsUrl}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ const SnapshotRestoreAppLink: React.FunctionComponent = () => {
// eslint-disable-next-line @elastic/eui/href-or-on-click
<EuiButton
href={snapshotRestoreUrl}
target="_blank"
onClick={() => {
uiMetricService.trackUiMetric(METRIC_TYPE.CLICK, UIM_BACKUP_DATA_ON_PREM_CLICK);
}}
Expand All @@ -46,12 +47,12 @@ export const OnPremBackup: React.FunctionComponent = () => {
<EuiText>
<p>
{i18n.translate('xpack.upgradeAssistant.overview.backupStepDescription', {
defaultMessage: 'Make sure you have a current snapshot before making any changes.',
defaultMessage: 'Make sure you have a current snapshot before proceeding.',
})}
</p>
</EuiText>

<EuiSpacer size="s" />
<EuiSpacer size="m" />

<SnapshotRestoreAppLink />
</>
Expand Down

0 comments on commit 5b68294

Please sign in to comment.