forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Dependency usage CLI (elastic#198920)
## Summary [dependency-cruiser](https://github.com/sverweij/dependency-cruiser/tree/main) is used for building dependency graph. ### Show all dependencies for a specific package/plugin or directory #### Run for all plugins ```bash bash scripts/dependency_usage.sh -p x-pack/plugins -o ./tmp/deps-result-all.json ``` #### Run for single plugin ```bash bash scripts/dependency_usage.sh -p x-pack/plugins/security_solution -o ./tmp/deps-result-single.json ``` #### Run for multiple plugins ```bash bash scripts/dependency_usage.sh -p x-pack/plugins/security_solution x-pack/plugins/security -o ./tmp/deps-result-multiple.json ``` #### Run for `x-pack/packages` ```bash bash scripts/dependency_usage.sh -p x-pack/packages -o ./tmp/deps-packages-1.json ``` #### Run for `packages` ```bash bash scripts/dependency_usage.sh -p packages -o ./tmp/deps-packages-2.json ``` #### Benchmark | Analysis | Real Time | User Time | Sys Time | |-----------------------|-------------|-------------|------------| | All plugins | 7m 21.126s | 7m 53.099s | 20.581s | | Single plugin | 31.360s | 45.352s | 2.208s | | Multiple plugins | 36.403s | 50.563s | 2.814s | | x-pack/packages | 6.638s | 12.646s | 0.654s | | packages | 25.744s | 39.073s | 2.191s | #### Show all packages/plugins within a directory that use a specific dependency ```sh bash scripts/dependency_usage.sh -d rxjs -p x-pack/plugins/security_solution ``` --- #### Show all packages/plugins within a directory grouped by code owner ```sh bash scripts/dependency_usage.sh -d rxjs -p x-pack/plugins -g owner ``` --- #### Group by code owner with adjustable collapse depth for fine-grained grouping **Fine-grained grouping**: ```sh bash scripts/dependency_usage.sh -p x-pack/plugins/security_solution -g owner --collapse-depth 4 ``` **Collapsed grouping**: groups the results under a higher-level owner (e.g., `security_solution` as a single group). ```bash bash scripts/dependency_usage.sh -p x-pack/plugins/security_solution -g owner --collapse-depth 1 ``` --- #### Show all dependencies matching a pattern (e.g., `react-*`) within a package ```bash bash scripts/dependency_usage.sh -p x-pack/plugins/security_solution -d 'react-*' -o ./tmp/result.json ``` ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios __Related: https://github.com/elastic/kibana/issues/196767__ --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
- Loading branch information
1 parent
5d6d45c
commit 34bf83b
Showing
31 changed files
with
1,779 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,153 @@ | ||
|
||
# @kbn/dependency-usage | ||
|
||
A CLI tool for analyzing dependencies across packages and plugins. This tool provides commands to check dependency usage, aggregate it, debug dependency graphs, and more. | ||
|
||
--- | ||
|
||
## Table of Contents | ||
1. [Show all packages/plugins using a dependency](#show-all-packagesplugins-using-a-dependency) | ||
2. [Show dependencies grouped by code owner](#show-dependencies-grouped-by-code-owner) | ||
3. [List all dependencies for a package or directory](#list-all-dependencies-for-source-directory) | ||
4. [Group by code owner with adjustable collapse depth](#group-by-code-owner-with-adjustable-collapse-depth) | ||
5. [Show dependencies matching a pattern](#show-dependencies-matching-a-pattern) | ||
6. [Verbose flag to debug dependency graph issues](#verbose-flag-to-debug-dependency-graph-issues) | ||
|
||
--- | ||
|
||
|
||
### 1. Show all packages/plugins using a specific dependency | ||
|
||
Use this command to list all packages or plugins within a directory that use a specified dependency. | ||
|
||
```sh | ||
bash scripts/dependency_usage.sh -d <dependency> -p <path_to_directory> | ||
``` | ||
or | ||
```sh | ||
bash scripts/dependency_usage.sh --dependency-name <dependency> --paths <path_to_directory> | ||
``` | ||
|
||
**Example**: | ||
```sh | ||
bash scripts/dependency_usage.sh -d rxjs -p x-pack/plugins/security_solution | ||
``` | ||
|
||
- `-d rxjs`: Specifies the dependency to look for (`rxjs`). | ||
- `-p x-pack/plugins/security_solution`: Sets the directory to search within (`x-pack/plugins/security_solution`). | ||
|
||
--- | ||
|
||
### 2. Show dependencies grouped by code owner | ||
|
||
Group the dependencies used within a directory by code owner. | ||
|
||
```sh | ||
bash scripts/dependency_usage.sh -p <path_to_directory> -g owner | ||
``` | ||
or | ||
```sh | ||
bash scripts/dependency_usage.sh --paths <path_to_directory> --group-by owner | ||
``` | ||
|
||
**Example**: | ||
```sh | ||
bash scripts/dependency_usage.sh -p x-pack/plugins -g owner | ||
``` | ||
|
||
- `-p x-pack/plugins`: Sets the directory to scan for plugins using this dependency. | ||
- `-g owner`: Groups results by code owner. | ||
- **Output**: Lists all dependencies for `x-pack/plugins`, organized by code owner. | ||
|
||
--- | ||
|
||
### 3. List all dependencies for source directory | ||
|
||
To display all dependencies used within a specific directory. | ||
|
||
```sh | ||
bash scripts/dependency_usage.sh -p <path_to_directory> | ||
``` | ||
or | ||
```sh | ||
bash scripts/dependency_usage.sh --paths <path_to_directory> | ||
``` | ||
|
||
**Example**: | ||
```sh | ||
bash scripts/dependency_usage.sh -p x-pack/plugins/security_solution | ||
``` | ||
|
||
- `-p x-pack/plugins/security_solution`: Specifies the package or directory for which to list all dependencies. | ||
- **Output**: Lists all dependencies for `x-pack/plugins/security_solution`. | ||
|
||
--- | ||
|
||
### 4. Group by code owner with adjustable collapse depth | ||
|
||
When a package or plugin has multiple subteams, use the `--collapse-depth` option to control how granular the grouping by code owner should be. | ||
|
||
#### Detailed Subteam Grouping | ||
Shows all subteams within `security_solution`. | ||
|
||
```sh | ||
bash scripts/dependency_usage.sh -p x-pack/plugins/security_solution -g owner --collapse-depth 4 | ||
``` | ||
|
||
#### Collapsed Grouping | ||
Groups the results under a higher-level owner (e.g., `security_solution` as a single group). | ||
|
||
```sh | ||
bash scripts/dependency_usage.sh -p x-pack/plugins/security_solution -g owner --collapse-depth 1 | ||
``` | ||
|
||
**Explanation**: | ||
- `-p x-pack/plugins/security_solution`: Specifies the directory to scan. | ||
- `-g owner`: Groups results by code owner. | ||
- `--collapse-depth`: Defines the depth for grouping, where higher numbers show more granular subteams. | ||
- **Output**: Lists dependencies grouped by code owner at different levels of depth based on the `--collapse-depth` value. | ||
|
||
--- | ||
|
||
### 5. Show dependencies matching a pattern | ||
|
||
Search for dependencies that match a specific pattern (such as `react-*`) within a package and output the results to a specified file. | ||
|
||
```sh | ||
bash scripts/dependency_usage.sh -p <path_to_directory> -d '<pattern>' -o <output_file> | ||
``` | ||
|
||
**Example**: | ||
```sh | ||
bash scripts/dependency_usage.sh -d 'react-*' -p x-pack/plugins/security_solution -o ./tmp/results.json | ||
``` | ||
|
||
- `-p x-pack/plugins/security_solution`: Specifies the directory or package to search within. | ||
- `-d 'react-*'`: Searches for dependencies that match the pattern `react-*`. | ||
- `-o ./tmp/results.json`: Outputs the results to a specified file (`results.json` in the `./tmp` directory). | ||
- **Output**: Saves a list of all dependencies matching `react-*` in `x-pack/plugins/security_solution` to `./tmp/results.json`. | ||
|
||
--- | ||
|
||
### 6. Verbose flag to debug dependency graph issues | ||
|
||
Enable verbose mode to log additional details for debugging dependency graphs. This includes generating a non-aggregated dependency graph in `.dependency-graph-log.json`. | ||
|
||
```sh | ||
bash scripts/dependency_usage.sh -p <path_to_directory> -o <output_file> -v | ||
``` | ||
|
||
**Example**: | ||
```sh | ||
bash scripts/dependency_usage.sh -p x-pack/plugins/security_solution -o ./tmp/results.json | ||
``` | ||
- `-p x-pack/plugins/security_solution`: Specifies the target directory or package to analyze. | ||
- `-o ./tmp/results.json`: Saves the output to the `results.json` file in the `./tmp` directory. | ||
- `-v`: Enables verbose mode. | ||
|
||
**Output**: Saves a list of all dependencies in `x-pack/plugins/security_solution` to `./tmp/results.json`. Additionally, it logs a detailed, non aggregated dependency graph to `.dependency-graph-log.json` for debugging purposes. | ||
|
||
--- | ||
|
||
For further information on additional flags and options, refer to the script's help command. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the "Elastic License | ||
* 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
* Public License v 1"; you may not use this file except in compliance with, at | ||
* your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
* License v3.0 only", or the "Server Side Public License, v 1". | ||
*/ | ||
|
||
/* eslint-disable no-restricted-syntax */ | ||
export default { | ||
preset: '@kbn/test', | ||
rootDir: '../..', | ||
roots: ['<rootDir>/packages/kbn-dependency-usage'], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"devOnly": true, | ||
"type": "shared-common", | ||
"id": "@kbn/dependency-usage", | ||
"owner": "@elastic/kibana-security" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"extends": "../../tsconfig.base.json", | ||
"name": "@kbn/dependency-usage", | ||
"private": true, | ||
"version": "1.0.0", | ||
"license": "Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0", | ||
"type": "module", | ||
"exports": { | ||
"./src/*": "./src/*" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the "Elastic License | ||
* 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
* Public License v 1"; you may not use this file except in compliance with, at | ||
* your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
* License v3.0 only", or the "Server Side Public License, v 1". | ||
*/ | ||
|
||
import { identifyDependencyUsageWithCruiser } from './dependency_graph/providers/cruiser.ts'; | ||
import { configureYargs } from './cli'; | ||
|
||
jest.mock('chalk', () => ({ | ||
green: jest.fn((str) => str), | ||
yellow: jest.fn((str) => str), | ||
cyan: jest.fn((str) => str), | ||
magenta: jest.fn((str) => str), | ||
blue: jest.fn((str) => str), | ||
bold: { magenta: jest.fn((str) => str), blue: jest.fn((str) => str) }, | ||
})); | ||
|
||
jest.mock('./dependency_graph/providers/cruiser', () => ({ | ||
identifyDependencyUsageWithCruiser: jest.fn(), | ||
})); | ||
|
||
jest.mock('./cli', () => ({ | ||
...jest.requireActual('./cli'), | ||
runCLI: jest.fn(), | ||
})); | ||
|
||
describe('dependency-usage CLI', () => { | ||
const parser = configureYargs() | ||
.fail((message: string) => { | ||
throw new Error(message); | ||
}) | ||
.exitProcess(false); | ||
|
||
beforeEach(() => { | ||
jest.spyOn(console, 'log').mockImplementation(() => {}); | ||
}); | ||
|
||
afterEach(() => { | ||
jest.resetAllMocks(); | ||
}); | ||
|
||
it('should handle verbose option', () => { | ||
const argv = parser.parse(['--paths', './plugins', '--verbose']); | ||
expect(argv.verbose).toBe(true); | ||
|
||
expect(identifyDependencyUsageWithCruiser).toHaveBeenCalledWith( | ||
expect.any(Array), | ||
undefined, | ||
expect.objectContaining({ isVerbose: true }) | ||
); | ||
}); | ||
|
||
it('should group results by specified group-by option', () => { | ||
const argv = parser.parse(['--paths', './src', '--group-by', 'owner']); | ||
expect(argv['group-by']).toBe('owner'); | ||
|
||
expect(identifyDependencyUsageWithCruiser).toHaveBeenCalledWith( | ||
expect.any(Array), | ||
undefined, | ||
expect.objectContaining({ groupBy: 'owner' }) | ||
); | ||
}); | ||
|
||
it('should use default values when optional arguments are not provided', () => { | ||
const argv = parser.parse([]); | ||
expect(argv.paths).toEqual(['.']); | ||
expect(argv['dependency-name']).toBeUndefined(); | ||
expect(argv['collapse-depth']).toBe(1); | ||
expect(argv.verbose).toBe(false); | ||
}); | ||
|
||
it('should throw an error if summary is used without dependency-name', () => { | ||
expect(() => { | ||
parser.parse(['--summary', '--paths', './src']); | ||
}).toThrow('Summary option can only be used when a dependency name is provided'); | ||
}); | ||
|
||
it('should validate collapse-depth as a positive integer', () => { | ||
expect(() => { | ||
parser.parse(['--paths', './src', '--collapse-depth', '0']); | ||
}).toThrow('Collapse depth must be a positive integer'); | ||
}); | ||
|
||
it('should output results to specified output path', () => { | ||
const argv = parser.parse(['--paths', './src', '--output-path', './output.json']); | ||
expect(argv['output-path']).toBe('./output.json'); | ||
}); | ||
|
||
it('should print results to console if no output path is specified', () => { | ||
const argv = parser.parse(['--paths', './src']); | ||
expect(argv['output-path']).toBeUndefined(); | ||
}); | ||
}); |
Oops, something went wrong.