Sustainable Kibana Architecture: Move modules owned by `@elastic/secu…

…rity-threat-hunting-investigations` (elastic#202855) ## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. #### 2 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/threat-intelligence-plugin` | `x-pack/solutions/security/plugins/threat_intelligence` | | `@kbn/timelines-plugin` | `x-pack/solutions/security/plugins/timelines` | #### 2 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/expandable-flyout` | `x-pack/solutions/security/packages/kbn-expandable-flyout` | | `@kbn/securitysolution-data-table` | `x-pack/solutions/security/packages/data_table` | Co-authored-by: PhilippeOberti <[email protected]> Co-authored-by: kibanamachine <[email protected]>
kapral18 · Dec 12, 2024 · 33c18c7 · 33c18c7
1 parent 749eeec
commit 33c18c7
Show file tree

Hide file tree

Showing 457 changed files with 274 additions and 353 deletions.
diff --git a/.buildkite/scripts/pipelines/pull_request/pipeline.ts b/.buildkite/scripts/pipelines/pull_request/pipeline.ts
@@ -248,7 +248,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
         /^x-pack\/plugins\/security_solution_ess/,
         /^x-pack\/plugins\/security_solution_serverless/,
         /^x-pack\/plugins\/task_manager/,
-        /^x-pack\/plugins\/timelines/,
+        /^x-pack\/solutions\/security\/plugins\/timelines/,
         /^x-pack\/plugins\/triggers_actions_ui\/public\/application\/sections\/action_connector_form/,
         /^x-pack\/plugins\/triggers_actions_ui\/public\/application\/context\/actions_connectors_context\.tsx/,
         /^x-pack\/plugins\/triggers_actions_ui\/server\/connector_types\/openai/,
@@ -290,7 +290,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
         /^packages\/kbn-es-query/,
         /^packages\/kbn-i18n/,
         /^packages\/kbn-i18n-react/,
-        /^packages\/kbn-expandable-flyout/,
+        /^x-pack\/solutions\/security\/packages\/expandable-flyout/,
         /^packages\/kbn-grouping/,
         /^packages\/kbn-resizable-layout/,
         /^packages\/kbn-rison/,
@@ -334,8 +334,8 @@ const getPipeline = (filename: string, removeSteps = true) => {
         /^x-pack\/plugins\/security_solution_ess/,
         /^x-pack\/plugins\/security_solution_serverless/,
         /^x-pack\/plugins\/task_manager/,
-        /^x-pack\/plugins\/threat_intelligence/,
-        /^x-pack\/plugins\/timelines/,
+        /^x-pack\/solutions\/security\/plugins\/threat_intelligence/,
+        /^x-pack\/solutions\/security\/plugins\/timelines/,
         /^x-pack\/plugins\/triggers_actions_ui/,
         /^x-pack\/plugins\/usage_collection\/public/,
         /^x-pack\/test\/functional\/es_archives\/security_solution/,

diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1109,8 +1109,8 @@ module.exports = {
         'x-pack/plugins/security_solution/common/**/*.{js,mjs,ts,tsx}',
         'x-pack/plugins/security_solution_ess/common/**/*.{js,mjs,ts,tsx}',
         'x-pack/plugins/security_solution_serverless/common/**/*.{js,mjs,ts,tsx}',
-        'x-pack/plugins/timelines/public/**/*.{js,mjs,ts,tsx}',
-        'x-pack/plugins/timelines/common/**/*.{js,mjs,ts,tsx}',
+        'x-pack/solutions/security/plugins/timelines/public/**/*.{js,mjs,ts,tsx}',
+        'x-pack/solutions/security/plugins/timelines/common/**/*.{js,mjs,ts,tsx}',
         'x-pack/plugins/cases/public/**/*.{js,mjs,ts,tsx}',
         'x-pack/plugins/cases/common/**/*.{js,mjs,ts,tsx}',
         'packages/kbn-cell-actions/**/*.{js,mjs,ts,tsx}',
@@ -1144,7 +1144,7 @@ module.exports = {
         'x-pack/plugins/security_solution/**/*.{ts,tsx}',
         'x-pack/plugins/security_solution_ess/**/*.{ts,tsx}',
         'x-pack/plugins/security_solution_serverless/**/*.{ts,tsx}',
-        'x-pack/plugins/timelines/**/*.{ts,tsx}',
+        'x-pack/solutions/security/plugins/timelines/**/*.{ts,tsx}',
         'x-pack/plugins/cases/**/*.{ts,tsx}',
         'packages/kbn-cell-actions/**/*.{js,mjs,ts,tsx}',
       ],
@@ -1159,7 +1159,7 @@ module.exports = {
         'x-pack/plugins/security_solution/**/*.{test,mock,test_helper}.{ts,tsx}',
         'x-pack/plugins/security_solution_ess/**/*.{test,mock,test_helper}.{ts,tsx}',
         'x-pack/plugins/security_solution_serverless/**/*.{test,mock,test_helper}.{ts,tsx}',
-        'x-pack/plugins/timelines/**/*.{test,mock,test_helper}.{ts,tsx}',
+        'x-pack/solutions/security/plugins/timelines/**/*.{test,mock,test_helper}.{ts,tsx}',
         'x-pack/plugins/cases/**/*.{test,mock,test_helper}.{ts,tsx}',
         'packages/kbn-cell-actions/**/*.{test,mock,test_helper}.{ts,tsx}',
       ],
@@ -1180,7 +1180,7 @@ module.exports = {
         'x-pack/plugins/security_solution/**/*.{ts,tsx}',
         'x-pack/plugins/security_solution_ess/**/*.{ts,tsx}',
         'x-pack/plugins/security_solution_serverless/**/*.{ts,tsx}',
-        'x-pack/plugins/timelines/**/*.{ts,tsx}',
+        'x-pack/solutions/security/plugins/timelines/**/*.{ts,tsx}',
         'x-pack/plugins/cases/**/*.{ts,tsx}',
         'packages/kbn-cell-actions/**/*.{ts,tsx}',
       ],
@@ -1214,7 +1214,7 @@ module.exports = {
         'x-pack/plugins/security_solution/**/*.{js,mjs,ts,tsx}',
         'x-pack/plugins/security_solution_ess/**/*.{js,mjs,ts,tsx}',
         'x-pack/plugins/security_solution_serverless/**/*.{js,mjs,ts,tsx}',
-        'x-pack/plugins/timelines/**/*.{js,mjs,ts,tsx}',
+        'x-pack/solutions/security/plugins/timelines/**/*.{js,mjs,ts,tsx}',
         'x-pack/plugins/cases/**/*.{js,mjs,ts,tsx}',
         'packages/kbn-data-stream-adapter/**/*.{js,mjs,ts,tsx}',
         'packages/kbn-cell-actions/**/*.{js,mjs,ts,tsx}',

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -351,7 +351,6 @@ packages/kbn-eslint-plugin-imports @elastic/kibana-operations
 packages/kbn-eslint-plugin-telemetry @elastic/obs-knowledge-team
 packages/kbn-event-annotation-common @elastic/kibana-visualizations
 packages/kbn-event-annotation-components @elastic/kibana-visualizations
-packages/kbn-expandable-flyout @elastic/security-threat-hunting-investigations
 packages/kbn-expect @elastic/kibana-operations @elastic/appex-qa
 packages/kbn-failed-test-reporter-cli @elastic/kibana-operations @elastic/appex-qa
 packages/kbn-field-types @elastic/kibana-data-discovery
@@ -966,8 +965,6 @@ x-pack/plugins/stack_alerts @elastic/response-ops
 x-pack/plugins/stack_connectors @elastic/response-ops
 x-pack/plugins/task_manager @elastic/response-ops
 x-pack/plugins/telemetry_collection_xpack @elastic/kibana-core
-x-pack/plugins/threat_intelligence @elastic/security-threat-hunting-investigations
-x-pack/plugins/timelines @elastic/security-threat-hunting-investigations
 x-pack/plugins/triggers_actions_ui @elastic/response-ops
 x-pack/plugins/upgrade_assistant @elastic/kibana-management
 x-pack/plugins/watcher @elastic/kibana-management
@@ -996,11 +993,14 @@ x-pack/solutions/observability/plugins/ux @elastic/obs-ux-management-team
 x-pack/solutions/security/packages/data_table @elastic/security-threat-hunting-investigations
 x-pack/solutions/security/packages/distribution_bar @elastic/kibana-cloud-security-posture
 x-pack/solutions/security/packages/ecs_data_quality_dashboard @elastic/security-threat-hunting-explore
+x-pack/solutions/security/packages/expandable-flyout @elastic/security-threat-hunting-investigations
 x-pack/solutions/security/packages/features @elastic/security-threat-hunting-explore
 x-pack/solutions/security/packages/navigation @elastic/security-threat-hunting-explore
 x-pack/solutions/security/packages/side_nav @elastic/security-threat-hunting-explore
 x-pack/solutions/security/packages/storybook/config @elastic/security-threat-hunting-explore
 x-pack/solutions/security/packages/upselling @elastic/security-threat-hunting-explore
+x-pack/solutions/security/plugins/threat_intelligence @elastic/security-threat-hunting-investigations
+x-pack/solutions/security/plugins/timelines @elastic/security-threat-hunting-investigations
 x-pack/test
 x-pack/test_serverless
 x-pack/test/alerting_api_integration/common/plugins/aad @elastic/response-ops
@@ -3353,7 +3353,7 @@ x-pack/solutions/security/packages/features @elastic/security-threat-hunting-exp
 x-pack/solutions/security/packages/kbn-cloud-security-posture/graph @elastic/kibana-cloud-security-posture
 x-pack/solutions/security/packages/kbn-cloud-security-posture/public @elastic/kibana-cloud-security-posture
 x-pack/solutions/security/packages/kbn-data-stream-adapter @elastic/security-threat-hunting
-x-pack/solutions/security/packages/kbn-expandable-flyout @elastic/security-threat-hunting-investigations
+x-pack/solutions/security/packages/expandable-flyout @elastic/security-threat-hunting-investigations
 x-pack/solutions/security/packages/kbn-index-adapter @elastic/security-threat-hunting
 x-pack/solutions/security/packages/kbn-securitysolution-autocomplete @elastic/security-detection-engine
 x-pack/solutions/security/packages/kbn-securitysolution-endpoint-exceptions-common @elastic/security-detection-engine

diff --git a/.github/codeql/codeql-config.yml b/.github/codeql/codeql-config.yml
@@ -84,6 +84,6 @@ paths-ignore:
   - x-pack/plugins/osquery/scripts
   - x-pack/plugins/rule_registry/scripts
   - x-pack/plugins/security_solution/scripts
-  - x-pack/plugins/threat_intelligence/scripts
+  - x-pack/solutions/security/plugins/threat_intelligence/scripts
   - x-pack/scripts
   - x-pack/test
diff --git a/.i18nrc.json b/.i18nrc.json
@@ -38,7 +38,6 @@
     "esQuery": "packages/kbn-es-query/src",
     "kbnGridLayout": "packages/kbn-grid-layout",
     "esUi": "src/plugins/es_ui_shared",
-    "expandableFlyout": "packages/kbn-expandable-flyout",
     "expressionError": "src/plugins/expression_error",
     "expressionGauge": "src/plugins/chart_expressions/expression_gauge",
     "expressionHeatmap": "src/plugins/chart_expressions/expression_heatmap",

diff --git a/docs/developer/plugin-list.asciidoc b/docs/developer/plugin-list.asciidoc
@@ -938,11 +938,11 @@ in their infrastructure.
 |Gathers all usage collection, retrieving them from both: OSS and X-Pack plugins.
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/threat_intelligence/README.md[threatIntelligence]
+|{kib-repo}blob/{branch}/x-pack/solutions/security/plugins/threat_intelligence/README.md[threatIntelligence]
 |Elastic Threat Intelligence makes it easy to analyze and investigate potential security threats by aggregating data from multiple sources in one place. You’ll be able to view data from all activated threat intelligence feeds and take action.
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/timelines/README.md[timelines]
+|{kib-repo}blob/{branch}/x-pack/solutions/security/plugins/timelines/README.md[timelines]
 |Timelines is a plugin that provides a grid component with accompanying server side apis to help users identify events of interest and perform root cause analysis within Kibana.
 
 

diff --git a/package.json b/package.json
@@ -504,7 +504,7 @@
     "@kbn/event-annotation-plugin": "link:src/plugins/event_annotation",
     "@kbn/event-log-fixture-plugin": "link:x-pack/test/plugin_api_integration/plugins/event_log",
     "@kbn/event-log-plugin": "link:x-pack/plugins/event_log",
-    "@kbn/expandable-flyout": "link:packages/kbn-expandable-flyout",
+    "@kbn/expandable-flyout": "link:x-pack/solutions/security/packages/expandable-flyout",
     "@kbn/exploratory-view-example-plugin": "link:x-pack/examples/exploratory_view_example",
     "@kbn/exploratory-view-plugin": "link:x-pack/solutions/observability/plugins/exploratory_view",
     "@kbn/expression-error-plugin": "link:src/plugins/expression_error",
@@ -960,8 +960,8 @@
     "@kbn/testing-embedded-lens-plugin": "link:x-pack/examples/testing_embedded_lens",
     "@kbn/third-party-lens-navigation-prompt-plugin": "link:x-pack/examples/third_party_lens_navigation_prompt",
     "@kbn/third-party-vis-lens-example-plugin": "link:x-pack/examples/third_party_vis_lens_example",
-    "@kbn/threat-intelligence-plugin": "link:x-pack/plugins/threat_intelligence",
-    "@kbn/timelines-plugin": "link:x-pack/plugins/timelines",
+    "@kbn/threat-intelligence-plugin": "link:x-pack/solutions/security/plugins/threat_intelligence",
+    "@kbn/timelines-plugin": "link:x-pack/solutions/security/plugins/timelines",
     "@kbn/timelion-grammar": "link:packages/kbn-timelion-grammar",
     "@kbn/timerange": "link:packages/kbn-timerange",
     "@kbn/tinymath": "link:packages/kbn-tinymath",

diff --git a/packages/deeplinks/security/deep_links.ts b/packages/deeplinks/security/deep_links.ts
@@ -72,7 +72,7 @@ export enum SecurityPageName {
   siemMigrationsRules = 'siem_migrations-rules',
   /*
    * Warning: Computed values are not permitted in an enum with string valued members
-   * All threat intelligence page names must match `TIPageId` in x-pack/plugins/threat_intelligence/public/common/navigation/types.ts
+   * All threat intelligence page names must match `TIPageId` in x-pack/solutions/security/plugins/threat_intelligence/public/common/navigation/types.ts
    */
   threatIntelligence = 'threat_intelligence',
   timelines = 'timelines',

diff --git a/packages/kbn-babel-preset/styled_components_files.js b/packages/kbn-babel-preset/styled_components_files.js
@@ -17,6 +17,7 @@ module.exports = {
     /src[\/\\]plugins[\/\\](kibana_react)[\/\\]/,
     /x-pack[\/\\]solutions[\/\\]observability[\/\\]plugins[\/\\]/,
     /x-pack[\/\\]plugins[\/\\](observability_solution\/apm|beats_management|fleet|observability_solution\/infra|lists|observability_solution\/observability|observability_solution\/observability_shared|observability_solution\/exploratory_view|security_solution|timelines|observability_solution\/synthetics|observability_solution\/ux|observability_solution\/uptime)[\/\\]/,
+    /x-pack[\/\\]solutions[\/\\]security[\/\\]plugins[\/\\](observability_solution\/apm|beats_management|fleet|observability_solution\/infra|lists|observability_solution\/observability|observability_solution\/observability_shared|observability_solution\/exploratory_view|security_solution|timelines|observability_solution\/synthetics|observability_solution\/ux|observability_solution\/uptime)[\/\\]/,
     /x-pack[\/\\]test[\/\\]plugin_functional[\/\\]plugins[\/\\]resolver_test[\/\\]/,
     /x-pack[\/\\]packages[\/\\]elastic_assistant[\/\\]/,
     /x-pack[\/\\]solutions[\/\\]security[\/\\]packages[\/\\]ecs_data_quality_dashboard[\/\\]/,

diff --git a/packages/kbn-expandable-flyout/.storybook/main.js b/packages/kbn-expandable-flyout/.storybook/main.js
diff --git a/packages/kbn-expandable-flyout/jest.config.js b/packages/kbn-expandable-flyout/jest.config.js
diff --git a/packages/kbn-expandable-flyout/src/components/translations.ts b/packages/kbn-expandable-flyout/src/components/translations.ts
diff --git a/src/dev/storybook/aliases.ts b/src/dev/storybook/aliases.ts
@@ -31,7 +31,7 @@ export const storybookAliases = {
   discover: 'src/plugins/discover/.storybook',
   esql_ast_inspector: 'examples/esql_ast_inspector/.storybook',
   es_ui_shared: 'src/plugins/es_ui_shared/.storybook',
-  expandable_flyout: 'packages/kbn-expandable-flyout/.storybook',
+  expandable_flyout: 'x-pack/solutions/security/packages/kbn-expandable-flyout/.storybook',
   expression_error: 'src/plugins/expression_error/.storybook',
   expression_image: 'src/plugins/expression_image/.storybook',
   expression_metric_vis: 'src/plugins/chart_expressions/expression_legacy_metric/.storybook',
@@ -67,7 +67,7 @@ export const storybookAliases = {
   serverless: 'packages/serverless/storybook/config',
   shared_ux: 'packages/shared-ux/storybook/config',
   slo: 'x-pack/plugins/observability_solution/slo/.storybook',
-  threat_intelligence: 'x-pack/plugins/threat_intelligence/.storybook',
+  threat_intelligence: 'x-pack/solutions/security/plugins/threat_intelligence/.storybook',
   triggers_actions_ui: 'x-pack/plugins/triggers_actions_ui/.storybook',
   ui_actions_enhanced: 'src/plugins/ui_actions_enhanced/.storybook',
   unified_search: 'src/plugins/unified_search/.storybook',

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -892,8 +892,8 @@
       "@kbn/event-log-fixture-plugin/*": ["x-pack/test/plugin_api_integration/plugins/event_log/*"],
       "@kbn/event-log-plugin": ["x-pack/plugins/event_log"],
       "@kbn/event-log-plugin/*": ["x-pack/plugins/event_log/*"],
-      "@kbn/expandable-flyout": ["packages/kbn-expandable-flyout"],
-      "@kbn/expandable-flyout/*": ["packages/kbn-expandable-flyout/*"],
+      "@kbn/expandable-flyout": ["x-pack/solutions/security/packages/expandable-flyout"],
+      "@kbn/expandable-flyout/*": ["x-pack/solutions/security/packages/expandable-flyout/*"],
       "@kbn/expect": ["packages/kbn-expect"],
       "@kbn/expect/*": ["packages/kbn-expect/*"],
       "@kbn/exploratory-view-example-plugin": ["x-pack/examples/exploratory_view_example"],
@@ -1926,10 +1926,10 @@
       "@kbn/third-party-lens-navigation-prompt-plugin/*": ["x-pack/examples/third_party_lens_navigation_prompt/*"],
       "@kbn/third-party-vis-lens-example-plugin": ["x-pack/examples/third_party_vis_lens_example"],
       "@kbn/third-party-vis-lens-example-plugin/*": ["x-pack/examples/third_party_vis_lens_example/*"],
-      "@kbn/threat-intelligence-plugin": ["x-pack/plugins/threat_intelligence"],
-      "@kbn/threat-intelligence-plugin/*": ["x-pack/plugins/threat_intelligence/*"],
-      "@kbn/timelines-plugin": ["x-pack/plugins/timelines"],
-      "@kbn/timelines-plugin/*": ["x-pack/plugins/timelines/*"],
+      "@kbn/threat-intelligence-plugin": ["x-pack/solutions/security/plugins/threat_intelligence"],
+      "@kbn/threat-intelligence-plugin/*": ["x-pack/solutions/security/plugins/threat_intelligence/*"],
+      "@kbn/timelines-plugin": ["x-pack/solutions/security/plugins/timelines"],
+      "@kbn/timelines-plugin/*": ["x-pack/solutions/security/plugins/timelines/*"],
       "@kbn/timelion-grammar": ["packages/kbn-timelion-grammar"],
       "@kbn/timelion-grammar/*": ["packages/kbn-timelion-grammar/*"],
       "@kbn/timerange": ["packages/kbn-timerange"],

diff --git a/x-pack/.i18nrc.json b/x-pack/.i18nrc.json
@@ -160,8 +160,8 @@
       "plugins/saved_objects_tagging"
     ],
     "xpack.taskManager": "legacy/plugins/task_manager",
-    "xpack.threatIntelligence": "plugins/threat_intelligence",
-    "xpack.timelines": "plugins/timelines",
+    "xpack.threatIntelligence": "solutions/security/plugins/threat_intelligence",
+    "xpack.timelines": "solutions/security/plugins/timelines",
     "xpack.transform": "platform/plugins/private/transform",
     "xpack.triggersActionsUI": "plugins/triggers_actions_ui",
     "xpack.upgradeAssistant": "plugins/upgrade_assistant",

diff --git a/x-pack/platform/plugins/private/translations/translations/fr-FR.json b/x-pack/platform/plugins/private/translations/translations/fr-FR.json
@@ -3122,17 +3122,6 @@
     "exceptionList-components.wildcardWithWrongOperatorCallout.changeTheOperator": "Changer d'opérateur",
     "exceptionList-components.wildcardWithWrongOperatorCallout.matches": "correspond à",
     "exceptionList-components.wildcardWithWrongOperatorCallout.title": "Veuillez examiner vos entrées",
-    "expandableFlyout.previewSection.backButton": "Retour",
-    "expandableFlyout.previewSection.closeButton": "Fermer",
-    "expandableFlyout.renderMenu.flyoutResizeButton": "Réinitialiser la taille",
-    "expandableFlyout.renderMenu.flyoutResizeTitle": "Taille du menu volant",
-    "expandableFlyout.settingsMenu.flyoutTypeTitle": "Type de menu volant",
-    "expandableFlyout.settingsMenu.overlayMode": "Superposer",
-    "expandableFlyout.settingsMenu.overlayTooltip": "Affiche le menu volant sur la page",
-    "expandableFlyout.settingsMenu.popoverButton": "Paramètres du menu volant",
-    "expandableFlyout.settingsMenu.popoverTitle": "Paramètres du menu volant",
-    "expandableFlyout.settingsMenu.pushMode": "Déploiement",
-    "expandableFlyout.settingsMenu.pushTooltip": "Affiche le menu volant à côté de la page",
     "expressionError.errorComponent.description": "Échec de l'expression avec le message :",
     "expressionError.errorComponent.title": "Oups ! Échec de l'expression",
     "expressionError.renderer.debug.displayName": "Déboguer",