Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ValueError in invalid_challenge #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JensGutermuth
Copy link

The error message may contain spaces and seems to be not quoted by dehydrated.

The error this fixes looks like this in the logs:

 + CloudFlare hook executing: invalid_challenge
Traceback (most recent call last):
  File "/opt/dehydrated-cloudflare-hook/hook.py", line 207, in <module>
    main(sys.argv[1:])
  File "/opt/dehydrated-cloudflare-hook/hook.py", line 204, in main
    ops[argv[0]](argv[1:])
  File "/opt/dehydrated-cloudflare-hook/hook.py", line 159, in invalid_challenge
    domain, result = args
ValueError: too many values to unpack (expected 2)

with the fix this turns into:

 + CloudFlare hook executing: invalid_challenge
 + invalid_challenge for *.[redacted]
 + Full error: { "type": "dns-01", "status": "invalid", "error": { "type": "urn:ietf:params:acme:error:unauthorized", "detail": "No TXT record found at _acme-challenge.[redacted]", "status": 403 }, "url": "https://acme-v02.api.letsencrypt.org/acme/challenge/[redacted]", "token": "[redacted]" }
ERROR: Challenge is invalid! (returned: invalid) (result: {
  "type": "dns-01",
  "status": "invalid",
  "error": {
    "type": "urn:ietf:params:acme:error:unauthorized",
    "detail": "No TXT record found at _acme-challenge.[redacted]",
    "status": 403
  },
  "url": "https://acme-v02.api.letsencrypt.org/acme/challenge/[redacted]",
  "token": "[redacted]"
})

The error message may contain spaces and seems to be not quoted by dehydrated.

The error this fixes looks like this in the logs:

 + CloudFlare hook executing: invalid_challenge
Traceback (most recent call last):
  File "/opt/dehydrated-cloudflare-hook/hook.py", line 207, in <module>
    main(sys.argv[1:])
  File "/opt/dehydrated-cloudflare-hook/hook.py", line 204, in main
    ops[argv[0]](argv[1:])
  File "/opt/dehydrated-cloudflare-hook/hook.py", line 159, in invalid_challenge
    domain, result = args
ValueError: too many values to unpack (expected 2)

with the fix this turns into:

 + CloudFlare hook executing: invalid_challenge
 + invalid_challenge for *.[redacted]
 + Full error: { "type": "dns-01", "status": "invalid", "error": { "type": "urn:ietf:params:acme:error:unauthorized", "detail": "No TXT record found at _acme-challenge.[redacted]", "status": 403 }, "url": "https://acme-v02.api.letsencrypt.org/acme/challenge/[redacted]", "token": "[redacted]" }
ERROR: Challenge is invalid! (returned: invalid) (result: {
  "type": "dns-01",
  "status": "invalid",
  "error": {
    "type": "urn:ietf:params:acme:error:unauthorized",
    "detail": "No TXT record found at _acme-challenge.[redacted]",
    "status": 403
  },
  "url": "https://acme-v02.api.letsencrypt.org/acme/challenge/[redacted]",
  "token": "[redacted]"
})
@YasharF
Copy link

YasharF commented May 18, 2019

This repo is no longer actively maintained. https://github.com/SeattleDevs/letsencrypt-cloudflare-hook is the maintained forked. I have cherry picked your commit and added it to that repo. Feel free to open future PRs in that repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants