Fixed processors to use appropriate config #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuggins
force-pushed
the
bug/processor-config
branch
from
723f7ce to
882f28e
Compare
mhuggins
force-pushed
the
bug/processor-config
branch
from
c879686 to
f79430e
Compare
|
@brandonc Just tested this and it's working. Interested in your feedback on the approach. Basically I changed all processors from modules w/ module methods to instantiable classes that accept the config object. The config object is used to determine the appropriate logger, async exit proc, etc. |
mhuggins
force-pushed
the
bug/processor-config
branch
from
f79430e to
f225b41
Compare
|
Closing since this is stale. Open to this being taken over by anyone who needs it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP, buthoping to get some eyes on it as a fix for #54.We're currently using the subscriber config for all asynchronous processing, even in spots where we should be using the publisher config. This changes the behavior and implementation of processors to make them instantiable classes that accept the config they should be working with. I also introduced a new
Poolmodule that is responsible for tracking all async processors and flushing properly. (Need to add tests for this still.)