-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): support ref-tags with default values #13
base: develop
Are you sure you want to change the base?
Conversation
Now you can write '${my:tag|default}'. if 'my:tag' could not resolved, the default value gets taken. Breaking Changes: Now you can't have the '|' - pipe symbol in your ref-tags anymore
feat(parser): support ref-tags with default values
this fits better with the kapitan ecosystem and reduces cases where a single pipe would break
This is a replacement for #11 , because of bad references on the branch |
@MatteoVoges for now add it here: https://github.com/kapicorp/reclass/blob/develop/README-extensions.rst |
|
Thank you, it was quite hard to find the correct spot where the tests need to go, because the nested interpolation logic doesn't happen in the modules where the feature comes to action... But I think its fine to do it in the parameters tests |
Proposed Changes
${spec:value||${default:value||another-default}}
||
as delimiter, because it fits well in the kapitan ecosystemExamples
Breaking changes
||
- delimiter in your yaml-keys anymore!To Do
@ademariag Where should this be done?
Contributed by