Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add find-wallet-depths command: quickly find walletdepths from master secret #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jokpine
Copy link

@jokpine jokpine commented May 26, 2022

No description provided.

@jokpine jokpine changed the title Add find-wallet-depths command: a tool for quickly finding walletdepths Add find-wallet-depths command: quickly find walletdepths from master secret May 26, 2022
@jokpine jokpine force-pushed the find-wallet-depths branch from 549c79b to f51bbf4 Compare May 27, 2022 06:41
@kanzure
Copy link
Owner

kanzure commented May 27, 2022

isn't this functionality already available with recover?

@jokpine
Copy link
Author

jokpine commented May 29, 2022

This command is meant as a very quick "100% safe" way (thanks to being read-only) to confirm/verify the walletdepths reported by webcash recover or webcash info. The algorithm used makes it much faster than webcash recover for large wallets.

This is command is likely to be used only by advanced users with large wallets so if we are to add this command it could make sense to add it behind a hidden=True flag to make it not show up in webcash help.

@kanzure
Copy link
Owner

kanzure commented May 29, 2022

Maybe this should share some of the batching code with the other function if the logic is meant to be similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants