sqlx + nextest: stabilization #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s373r
force-pushed
the
chore/sqlx-nextest-stabilization
branch
from
0875395
to
2ac4e3f
Compare
s373r
requested review from
sergiimk,
rmn-boiko,
demusdev and
zaychenko-sergei
and removed request for
sergiimk
s373r
commented
Oct 23, 2024
| @@ -13,8 +13,8 @@ Recommendation: for ease of reading, use the following order: | |||
|
|
|||
| ## [Unreleased] | |||
| ### Changed | |||
| - ObjectRepositoryS3`: can now support external address configuration | |||
| # TODO: Delete this workaround when this PR is merged: | ||
| # - Fix: nextest cleanup race condition by bonega | ||
| # https://github.com/launchbadge/sqlx/pull/3334 | ||
| sqlx = { git = 'https://github.com/kamu-data/sqlx', branch = 'nextest-race-condition' } |
There was a problem hiding this comment.
Comment for readers: originally I thought of patching only the use of sqlx in tests, but after studying the commit differences, I came to the point where I could use it in general. That made this update very easy
There was a problem hiding this comment.
It's fine as long as the build stabilizes
s373r
force-pushed
the
chore/sqlx-nextest-stabilization
branch
from
2ac4e3f
to
ac307da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the patched version of
sqlx:Checklist before requesting a review