Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pano feed filters #680

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Pano feed filters #680

merged 4 commits into from
Aug 18, 2023

Conversation

usirin
Copy link
Member

@usirin usirin commented Aug 18, 2023

Start supporting the filters on pano home page filters.

Checklist

  • discord username: umut
  • Closes feat(pano): rename filters & update routes with correct structure for panoFeed #610
  • Closes feat(gql): update Viewer.panoFeed to accept feed filters #611
  • PR must be created for an issue from issues under "In progress" column from our project board.
  • A descriptive and understandable title: The PR title should clearly describe the nature and purpose of the changes. The PR title should be the first thing displayed when the PR is opened. And it should follow the semantic commit rules, and should include the app/package/service name in the title. For example, a title like "docs(@kampus-apps/pano): Add README.md" can be used.
  • Related file selection: Only relevant files should be touched and no other files should be affected.
  • I ran npx turbo run at the root of the repository, and build was successful.
  • I installed the npm packages using npm install --save-exact <package> so my package is pinned to a specific npm version. Leave empty if no package was installed. Leave empty if no package was installed with this PR.

@usirin usirin requested a review from a team as a code owner August 18, 2023 22:46
@vercel
Copy link

vercel bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kampus-gql ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 11:33pm
kampus-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 11:33pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
kampus-pasaport ⬜️ Ignored (Inspect) Visit Preview Aug 18, 2023 11:33pm
kampus-studio ⬜️ Ignored (Inspect) Visit Preview Aug 18, 2023 11:33pm

Copy link
Member

@rasitds rasitds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@usirin usirin merged commit 1176b88 into dev Aug 18, 2023
2 checks passed
@usirin usirin deleted the pano-feed-filters branch August 18, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants