Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps/ui): add missing stories #592

Merged
merged 9 commits into from
Aug 10, 2023
Merged

Conversation

Murat-tunca
Copy link
Contributor

@Murat-tunca Murat-tunca commented Aug 2, 2023

Description

Please describe your changes. Be descriptive enough to reduce churn for review process.

Checklist

  • discord username: murat.tunca
  • Issue: feat(apps/ui): add missing storybook stories #580
  • PR must be created for an issue from issues under "In progress" column from our project board.
  • A descriptive and understandable title: The PR title should clearly describe the nature and purpose of the changes. The PR title should be the first thing displayed when the PR is opened. And it should follow the semantic commit rules, and should include the app/package/service name in the title. For example, a title like "docs(@kampus-apps/pano): Add README.md" can be used.
  • Related file selection: Only relevant files should be touched and no other files should be affected.
  • I ran npx turbo run at the root of the repository, and build was successful.
  • I installed the npm packages using npm install --save-exact <package> so my package is pinned to a specific npm version. Leave empty if no package was installed. Leave empty if no package was installed with this PR.

How were these changes tested?

Please describe the tests you did to test the changes you made. Please also specify your test configuration.

@Murat-tunca Murat-tunca requested a review from a team as a code owner August 2, 2023 20:42
@vercel
Copy link

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kampus-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 8:36am
kampus-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 8:36am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
kampus-gql ⬜️ Ignored (Inspect) Visit Preview Aug 10, 2023 8:36am

@vercel
Copy link

vercel bot commented Aug 2, 2023

@Murat-tunca is attempting to deploy a commit to the kamp-us Team on Vercel.

A member of the Team first needs to authorize it.

@Ketcap
Copy link
Contributor

Ketcap commented Aug 3, 2023

If you fix the last checkbox that would be great. Packages being installed should not have "^x.x.x" it should be "x.x.x" exact version.

@usirin usirin requested review from cansirin and removed request for yavuzyalcintas and csoylu August 3, 2023 23:27
Copy link
Member

@usirin usirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LETS GOOOOOOOOOOOOOOOOOOOOO

Copy link
Contributor

@cansirin cansirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME CONTRIBUTION, THANK YOU <3 💯

@cansirin cansirin merged commit ddcd54d into kamp-us:dev Aug 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants