Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app/pano):used toast component #577

Merged
merged 11 commits into from
Aug 6, 2023
Merged

feat(app/pano):used toast component #577

merged 11 commits into from
Aug 6, 2023

Conversation

muhammed-gumus
Copy link
Collaborator

@muhammed-gumus muhammed-gumus commented Jul 30, 2023 •
edited
Loading

Description

Added Toast component that will be triggered when the Copy Link text in the DropDown Menu is clicked.

Checklist

  • discord username: muhammed-gumus
  • Closes feat(pano): Add toast for "Adresi Kopyala" action on the more options dropdown #568
  • PR must be created for an issue from issues under "In progress" column from our project board.
  • A descriptive and understandable title: The PR title should clearly describe the nature and purpose of the changes. The PR title should be the first thing displayed when the PR is opened. And it should follow the semantic commit rules, and should include the app/package/service name in the title. For example, a title like "docs(@kampus-apps/pano): Add README.md" can be used.
  • Related file selection: Only relevant files should be touched and no other files should be affected.
  • I ran npx turbo run at the root of the repository, and build was successful.
  • I installed the npm packages using npm install --save-exact <package> so my package is pinned to a specific npm version. Leave empty if no package was installed. Leave empty if no package was installed with this PR.

How were these changes tested?

Please describe the tests you did to test the changes you made. Please also specify your test configuration.

@muhammed-gumus muhammed-gumus requested a review from a team as a code owner July 30, 2023 21:49
@vercel
Copy link

vercel bot commented Jul 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kampus-gql ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2023 9:32pm
kampus-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2023 9:32pm
kampus-pasaport ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2023 9:32pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
kampus-ui ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2023 9:32pm

@vercel
Copy link

vercel bot commented Jul 30, 2023

Someone is attempting to deploy a commit to the kamp-us Team on Vercel.

A member of the Team first needs to authorize it.

@cansirin cansirin self-requested a review July 30, 2023 22:05
@cansirin cansirin added product/pano issues related to pano.kamp.us work in progress apps/kampus labels Jul 30, 2023
cansirin
cansirin reviewed Aug 2, 2023
View reviewed changes
apps/kampus/app/layout.tsx Outdated Show resolved Hide resolved
@Ketcap
Copy link
Contributor

Ketcap commented Aug 3, 2023

If you can make sure to go through checklist I would merge it immediately :)

@Ketcap Ketcap marked this pull request as draft August 3, 2023 20:41
@muhammed-gumus muhammed-gumus changed the title used toast component feat(app/pano):used toast component Aug 4, 2023
usirin
usirin requested changes Aug 4, 2023
View reviewed changes
Copy link
Member

@usirin usirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look pretty good, though we need to run prettier on the changed files. @cansirin can you assist?

@usirin usirin added ready for review add this label when your PR is ready for review and removed work in progress labels Aug 4, 2023
@usirin usirin marked this pull request as ready for review August 4, 2023 22:17
cansirin
cansirin approved these changes Aug 6, 2023
View reviewed changes
Copy link
Contributor

@cansirin cansirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LETS GOOOOOOOO!

@cansirin cansirin merged commit 570f405 into kamp-us:dev Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usirin usirin usirin approved these changes

@cansirin cansirin cansirin approved these changes

@Ketcap Ketcap Ketcap approved these changes

Assignees

@cansirin cansirin

Labels
apps/kampus product/pano issues related to pano.kamp.us ready for review add this label when your PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muhammed-gumus @Ketcap @usirin @cansirin