Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gql): update Viewer.panoFeed to accept feed filters #611

Closed
Tracked by #566
usirin opened this issue Aug 8, 2023 · 0 comments · Fixed by #680
Closed
Tracked by #566

feat(gql): update Viewer.panoFeed to accept feed filters #611

usirin opened this issue Aug 8, 2023 · 0 comments · Fixed by #680
Assignees
@usirin
Labels
apps/gql issues related to our gql service product/pano issues related to pano.kamp.us

Comments

@usirin
Copy link
Member

usirin commented Aug 8, 2023 •
edited
Loading

We already have an enum in our graphql schema defined for this:

monorepo/apps/gql/schema/schema.graphql

Lines 104 to 110 in d454766

enum PanoPostFilter {
ALL
HOT
LIKED
ACTIVE
SELF
}

we want to rename it to PanoFeedFilters first, then update it correctly according to the spec we have in #566:

enum PanoFeedFilter {
  ALL
  ACTIVE # order by post.comment.createdAt DESC
  HOT # order by post.commentCount DESC
  UPVOTED # upvoted by viewer
  OWNED # created by viewer
}

Blocked by #617
@usirin usirin mentioned this issue Aug 8, 2023
Closed
20 tasks
@usirin usirin added product/pano issues related to pano.kamp.us apps/gql issues related to our gql service labels Aug 8, 2023
@usirin usirin added this to the kampus architecture v1 milestone Aug 8, 2023
@usirin usirin moved this from 🆕 New to 🔖 Ready in kampus architecture v1 Aug 8, 2023
@usirin usirin self-assigned this Aug 8, 2023
@usirin usirin moved this to 🔖 Ready in monorepo pano Aug 8, 2023
@usirin usirin mentioned this issue Aug 8, 2023
Closed
@usirin usirin removed this from the kampus architecture v1 milestone Aug 15, 2023
@usirin usirin mentioned this issue Aug 18, 2023
Merged
8 tasks
usirin added a commit that referenced this issue Aug 18, 2023
@usirin
Pano feed filters (#680)
1176b88 
Start supporting the filters on pano home page filters.

### Checklist

- [ ] discord username: `umut`
- [ ] Closes #610 
- [ ] Closes #611 
- [ ] PR must be created for an issue from issues under "In progress"
column from [our project
board](https://github.com/orgs/kamp-us/projects/2/views/1).
- [ ] A descriptive and understandable title: The PR title should
clearly describe the nature and purpose of the changes. The PR title
should be the first thing displayed when the PR is opened. And it should
follow the semantic commit rules, and should include the
app/package/service name in the title. For example, a title like
"docs(@kampus-apps/pano): Add README.md" can be used.
- [ ] Related file selection: Only relevant files should be touched and
no other files should be affected.
- [ ] I ran `npx turbo run` at the root of the repository, and build was
successful.
- [ ] I installed the npm packages using `npm install --save-exact
<package>` so my package is pinned to a specific npm version. Leave
empty if no package was installed. Leave empty if no package was
installed with this PR.
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in monorepo pano Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usirin usirin

Labels
apps/gql issues related to our gql service product/pano issues related to pano.kamp.us
Projects
monorepo pano
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pano feed filters kamp-us/monorepo
1 participant
@usirin