Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ADA-5): Volume control is not accessible from element list #811

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix(ADA-5): Volume control is not accessible from element list #811

merged 1 commit into from
Nov 7, 2023

Conversation

Tzipi-kaltura
Copy link
Contributor

@Tzipi-kaltura Tzipi-kaltura commented Nov 2, 2023 •
edited by jira bot
Loading

Description of the Changes

issue:
volume control is not displayed in jaws element list.

solution:
remove the role="application" part of 704 and it's not necessary anymore since we added tabindex on the volume slider.

solves ADA-5

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Tzipi-kaltura Tzipi-kaltura merged commit 0a1d0dc into master Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

@JonathanTGold JonathanTGold Awaiting requested review from JonathanTGold

@lianbenjamin lianbenjamin Awaiting requested review from lianbenjamin

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tzipi-kaltura @SivanA-Kaltura