Skip to content

Commit

Permalink
fix(ADA-95): Purpose of logo link on player is not clear in context (#…
Browse files Browse the repository at this point in the history
…814)

aria-label was [object object] instead of the strings from the translation object.

solves ADA-95
  • Loading branch information
Tzipi-kaltura authored Nov 21, 2023
1 parent f9902bd commit fef3444
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/components/logo/logo.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import style from '../../styles/style.scss';
import {h, Component} from 'preact';
import {connect} from 'react-redux';
import {Text} from 'preact-i18n';
import {withText} from 'preact-i18n';
import {withPlayer} from '../player';
import {withLogger} from 'components/logger';

Expand All @@ -29,6 +29,7 @@ const mapStateToProps = state => ({
@connect(mapStateToProps)
@withPlayer
@withLogger(COMPONENT_NAME)
@withText({logoText: 'controls.logo'})
class Logo extends Component {
/**
* should render component
Expand All @@ -54,7 +55,7 @@ class Logo extends Component {
return (
<div
className={[style.controlButtonContainer, !props.config.url ? style.emptyUrl : ''].join(' ')}
aria-label={<Text id="controls.logo" />}
aria-label={props.logoText}
title={props.config.text}>
<a className={style.controlButton} href={props.config.url} target="_blank" rel="noopener noreferrer">
<img className={style.icon} src={props.config.img} />
Expand Down

0 comments on commit fef3444

Please sign in to comment.