Skip to content

Commit

Permalink
fix(FEC-13604): Aliging the template ref with our new infra (#6)
Browse files Browse the repository at this point in the history
### Description of the Changes

Aliging the template ref with the TS refacotr

#### Resolves FEC-FEC-13604

#### Related PRs
kaltura/playkit-js-ui#843
kaltura/kaltura-player-js#704

---------

Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
  • Loading branch information
JonathanTGold and JonathanTGold authored Jan 24, 2024
1 parent 4ccd31c commit 77e760f
Show file tree
Hide file tree
Showing 42 changed files with 3,388 additions and 3,272 deletions.
2 changes: 2 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@ types/
demo/
webpack.config.js
tsconfig.json
tsconfig-lib.json
node_modules
.eslintrc.json
81 changes: 0 additions & 81 deletions .eslintrc

This file was deleted.

60 changes: 60 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
{
"root": true,
"parser": "@typescript-eslint/parser",
"extends": [
"plugin:prettier/recommended",
"plugin:@typescript-eslint/recommended",
"prettier"
],
"plugins": [
"prettier",
"@typescript-eslint"
],
"rules": {
"max-len": [
"error",
{
"code": 150,
"ignoreComments": true,
"ignoreStrings": true,
"ignoreUrls": true,
"ignoreTemplateLiterals": true,
"ignoreRegExpLiterals": true
}
],
"eol-last": "off",
"prettier/prettier": "error",
"@typescript-eslint/explicit-function-return-type": "warn",
"@typescript-eslint/no-non-null-assertion": "off",
"@typescript-eslint/no-unused-vars": "error",
"@typescript-eslint/no-explicit-any": "warn",
"@typescript-eslint/explicit-member-accessibility": [
"error",
{
"accessibility": "explicit",
"overrides": {
"accessors": "explicit",
"constructors": "no-public",
"methods": "explicit",
"properties": "explicit",
"parameterProperties": "explicit"
}
}
],
"block-scoped-var": "error",
"arrow-parens": "error",
"eqeqeq": "error",
"no-var": "error",
"no-console": "error",
"prefer-const": "error",
"prefer-arrow-callback": "error",
"no-trailing-spaces": "error",
"quotes": ["warn", "single", { "avoidEscape": true }]
},
"overrides": [],
"settings": {},
"env": {
"browser": true,
"es6": true
}
}
12 changes: 6 additions & 6 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.

### CheckLists
**Issue:**

**Fix:**

#### Resolves FEC-[Please add the ticket reference here]


- [ ] changes have been done against master branch, and PR does not conflict
- [ ] new unit / functional tests have been added (whenever applicable)
- [ ] test are passing in local environment
- [ ] Travis tests are passing (or test results are not worse than on master branch :))
- [ ] Docs have been updated
18 changes: 18 additions & 0 deletions .github/workflows/run_canary.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
## Canary CI/CD
name: Canary
run-name: Canary

on:
push:
branches:
- master

jobs:
canary:
if: ${{ github.actor != 'PlaykitJs-Bot' }}
uses: kaltura/playkit-js-common/.github/workflows/canary_plugin.yaml@master
secrets: inherit
with:
node-version: "20.x"
schema-type: "playerV3Versions"
tests-yarn-run-to-execute: 'build lint type-check test'
28 changes: 0 additions & 28 deletions .github/workflows/run_canary_full_flow.yaml

This file was deleted.

3 changes: 2 additions & 1 deletion .github/workflows/run_prod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ jobs:
PLAYER_MSTEAMS_WEBHOOK: ${{ secrets.PLAYER_MSTEAMS_WEBHOOK }}
PLAYER_GITHUB_BOT_TOKEN: ${{ secrets.PLAYER_GITHUB_BOT_TOKEN }}
with:
node-version: "20.x"
type: "plugin"
env: "prod"
schema-type: "playerV3Versions"
tests-yarn-run-to-execute: 'build lint:check types:check test'
tests-yarn-run-to-execute: 'build lint type-check test'
29 changes: 25 additions & 4 deletions .github/workflows/run_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,38 @@ on:
- "*"

jobs:
running-tests:
build:
uses: kaltura/ovp-pipelines-pub/.github/workflows/player_tests.yaml@master
with:
yarn-run-to-execute: 'build lint:check types:check test'
node-version: '20.x'
yarn-run-to-execute: 'build'
test:
uses: kaltura/ovp-pipelines-pub/.github/workflows/player_tests.yaml@master
with:
node-version: '20.x'
yarn-run-to-execute: 'test'
type-check:
uses: kaltura/ovp-pipelines-pub/.github/workflows/player_tests.yaml@master
with:
node-version: '20.x'
yarn-run-to-execute: 'type-check'
build-types:
uses: kaltura/ovp-pipelines-pub/.github/workflows/player_tests.yaml@master
with:
node-version: '20.x'
yarn-run-to-execute: 'build:types'
lint:
uses: kaltura/ovp-pipelines-pub/.github/workflows/player_tests.yaml@master
with:
node-version: '20.x'
yarn-run-to-execute: 'lint'
notification:
if: always()
uses: kaltura/ovp-pipelines-pub/.github/workflows/notification.yaml@master
needs: running-tests
needs: [build, test, type-check, lint]
secrets:
PLAYER_MSTEAMS_WEBHOOK: ${{ secrets.PLAYER_MSTEAMS_WEBHOOK }}
with:
failure-status: ${{ contains(needs.*.result, 'failure') }}
cancelled-status: ${{ contains(needs.*.result, 'cancelled') }}
is-test: 'true'
is-test: 'true'
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
dist/
lib/
demo/
node_modules
*.log
.idea
types/
5 changes: 5 additions & 0 deletions .idea/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

64 changes: 64 additions & 0 deletions .idea/codeStyles/Project.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions .idea/codeStyles/codeStyleConfig.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/compiler.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/inspectionProfiles/Project_Default.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/jsLibraryMappings.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions .idea/modules.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 77e760f

Please sign in to comment.