Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-13931): Audio player| canary audio player version failed to load #771

Merged
merged 2 commits into from
May 15, 2024

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented May 12, 2024

Description of the Changes

Issue: the gloabal back-end var window.__kalturaplayerdata is declared after the player and plugins code in bundle file

Fix: set a dedicated var for custom preset

Resolves FEC-13931

Related PR

kaltura/playkit-js-audio-player#20

@JonathanTGold JonathanTGold requested a review from a team May 12, 2024 10:31
@JonathanTGold JonathanTGold merged commit 68c1fd2 into master May 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants