Skip to content

Commit

Permalink
fix(FEC-13685): Captions advanced settings text style is not saved
Browse files Browse the repository at this point in the history
### Description of the Changes

**Issue:**
Captions style is not saved
The bug only affected captions style because other uses of storage
manager used StorageWrapper getItem directly

**Fix:**
Add return statement to BaseStorageManager.getItem and do not use
StorageWrapper getItem directly outside of BaseStorageManager.getItem

Resolves FEC-13685
  • Loading branch information
SivanA-Kaltura authored Feb 6, 2024
1 parent 46423a2 commit 6ad3832
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/common/storage/base-storage-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export class BaseStorageManager {
* @returns {any} - The item value
*/
public static getItem(key: string): any {
StorageWrapper.getItem(key, this.getStorageObject());
return StorageWrapper.getItem(key, this.getStorageObject());
}

/**
Expand Down Expand Up @@ -152,7 +152,7 @@ export class BaseStorageManager {
const obj = {};
Object.keys(this.StorageKeys).forEach((key) => {
const value = this.StorageKeys[key];
const item = StorageWrapper.getItem(value, this.getStorageObject());
const item = this.getItem(value);
// dont change to !==, it effects the logic
// eslint-disable-next-line
if (item != null) {
Expand Down

0 comments on commit 6ad3832

Please sign in to comment.