Skip to content
This repository has been archived by the owner on Nov 20, 2019. It is now read-only.

Url encode filename in bucket file on s3 request #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hodga
Copy link

@hodga hodga commented Dec 7, 2017

I found out it is not a signer issue.
First i tried encoding the path inside the Signer, but that required me to remove the encoding on "be able to add and delete files with 'weird' names" test. This again led to a Exception because of a invalid url inside WsRequest.

This might lead to backwards compatibility issue if someone else url encode their filenames already.
I guess it is possible to check if the filename already is encoded before encoding it, but i decided to keep it simple.

@EECOLOR
Copy link
Member

EECOLOR commented Dec 7, 2017

@hodga That's great. Make sure you reference the issue in the commit message: ... - fixes #89. Since this is a change that is not backwards compatible this change should result in a major version bump.

It would also be nice to add the workaround AwsUrlEncoder.encodePath to #89 for people that do not want to wait for or upgrade to a new major version.

Just for future wanderers, in the past we had a similar issue #19

@EECOLOR
Copy link
Member

EECOLOR commented Dec 8, 2017

Maybe @lucianenache can help you to release the new version once you have made the appropriate changes.

@hodga
Copy link
Author

hodga commented Dec 8, 2017

Updated, will also add the workaround on #89 :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants