-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BACK] feat(notifications): u#3965 add a periodic task and a command to delete read notifications #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bameda
force-pushed
the
us/3965/delete_read_notifications_periodically
branch
from
November 22, 2023 18:37
a844af3
to
4236815
Compare
Coverage Report
|
bameda
force-pushed
the
us/3965/delete_read_notifications_periodically
branch
from
November 22, 2023 20:18
4236815
to
b01d29b
Compare
bameda
changed the title
feat(notifications): u#3965 add a periodic task and a command to delete read notifications
[BACK] feat(notifications): u#3965 add a periodic task and a command to delete read notifications
Nov 22, 2023
…te read notifications
bameda
force-pushed
the
us/3965/delete_read_notifications_periodically
branch
from
November 23, 2023 08:23
b01d29b
to
9cde441
Compare
daniel-herrero
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A periodic task is created that will delete delete all notifications that have been read more than X minutes ago. (The frequency of the periodic task and time that the nitifications will be kept are configurable parameters).
There is a CLI command to remove read notifications too.
How to tests:
python -m taiga notifications clean-read-notifications --help