Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflow): Design review #527

Merged
merged 1 commit into from
Oct 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,28 @@ import {
EventEmitter,
Input,
OnChanges,
OnInit,
Output,
ViewChild,
} from '@angular/core';

import { CommonModule } from '@angular/common';
import { TranslocoDirective } from '@ngneat/transloco';
import { UntilDestroy, untilDestroyed } from '@ngneat/until-destroy';
import {
TuiButtonModule,
TuiDataListModule,
TuiHostedDropdownComponent,
TuiHostedDropdownModule,
TuiNotification,
TuiSvgModule,
} from '@taiga-ui/core';
import { StoryDetail, Workflow } from '@taiga/data';
import { Project, StoryDetail, Workflow } from '@taiga/data';
import { BreadcrumbComponent } from '@taiga/ui/breadcrumb/breadcrumb.component';
import { AppService } from '~/app/services/app.service';
import { WsService } from '~/app/services/ws';

@UntilDestroy()
@Component({
selector: 'tg-story-detail-workflow',
templateUrl: './story-detail-workflow.component.html',
Expand All @@ -44,12 +50,12 @@ import { BreadcrumbComponent } from '@taiga/ui/breadcrumb/breadcrumb.component';
TuiSvgModule,
],
})
export class StoryDetailWorkflowComponent implements OnChanges {
export class StoryDetailWorkflowComponent implements OnInit, OnChanges {
@Input({ required: true })
public story!: StoryDetail;

@Input({ required: true })
public workflows!: Workflow[];
public project!: Project;

@Input()
public canEdit = false;
Expand All @@ -63,8 +69,14 @@ export class StoryDetailWorkflowComponent implements OnChanges {
public openWorkflowList = false;
public filteredWorkflows: Workflow[] = [];

constructor(private wsService: WsService, private appService: AppService) {}

public ngOnInit(): void {
this.events();
}

public ngOnChanges(): void {
this.filteredWorkflows = this.workflows.filter(
this.filteredWorkflows = this.project.workflows.filter(
(workflow) => workflow.slug !== this.story.workflow.slug
);
}
Expand All @@ -78,4 +90,23 @@ export class StoryDetailWorkflowComponent implements OnChanges {
this.component?.nativeFocusableElement?.focus();
this.toWorkflow.emit(workflow);
}

public events() {
this.wsService
.projectEvents<{ story: StoryDetail }>('stories.update')
.pipe(untilDestroyed(this))
.subscribe((msg) => {
const workflowURL = `project/${this.project.id}/${this.project.slug}/kanban/${msg.event.content.story.workflow.slug}`;
this.appService.toastNotification({
message: 'move.confirm',
paramsMessage: {
workflowURL,
workflowName: msg.event.content.story.workflow.name,
},
status: TuiNotification.Info,
scope: 'story',
autoClose: true,
});
});
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export const StoryDetailActions = createActionGroup({
}>(),
'Update story workflow': props<{
story: StoryUpdate;
workflow: Workflow;
projectId: Project['id'];
}>(),
'Delete story': props<{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export class StoryDetailEffects {
if (httpResponse.status === 400) {
this.appService.toastNotification({
message: 'move.error',
paramsMessage: { workflow: action.story.workflow },
paramsMessage: { workflow: action.workflow.name },
status: TuiNotification.Error,
scope: 'story',
autoClose: true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
<tg-story-detail-workflow
*ngIf="vm.story"
[story]="vm.story"
[workflows]="vm.project.workflows"
[project]="vm.project"
[canEdit]="vm.canEdit"
(toWorkflow)="moveStoryToWorkflow($event)">
</tg-story-detail-workflow>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,7 @@ export class StoryDetailComponent {
this.store.dispatch(
StoryDetailActions.updateStoryWorkflow({
projectId: this.state.get('project').id,
workflow,
story,
})
);
Expand Down
3 changes: 2 additions & 1 deletion javascript/apps/taiga/src/assets/i18n/story/en-US.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"empty_description_view_permissions": "This story doesn't have a description yet.",
"edit_description": "Edit description",
"move": {
"error": "The workflow {{workflow}} does not have any status. Create one and try again."
"error": "The workflow {{workflow}} does not have any status. Create one and try again.",
"confirm": "The story has been moved to the <a href='{{workflowURL}}'> {{workflowName}} </a> workflow"
},
"delete": {
"delete_story": "Delete Story",
Expand Down