Advance model data #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.gradle.kts
# Conflicts: # common/src/main/java/org/kakara/core/common/game/Item.java # server/src/main/java/org/kakara/core/server/game/ServerItemStack.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModelData is a way to handle that Items and Entities will sometimes be the same behind the scene but is rendered differently.
Such as building a pick axe with a different coloured wood.
How will the game know which one to use.
Inside the Items onCraft Handler they will be able to set a ModelData value to the ItemMeta.
Data that a ModelDataObject can set.
This will break the current Kakara game and KVanilla mod slightly.
Currently under development.
Opinions are welcome in a constructive manner.
Example model-data.json
https://gist.github.com/wherkamp/ff72add43686b562fdec70c60a2f25d6