Some minor typo/bug fixes, and fix for issue #33 & #67. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normal(non-editing) mode
Currently, RIEInput : * defaults its <input> size to 20, which limits visibility of entered text that's longer. * only shows 20 characters when an RIEInput field is clicked on, to enter edit mode.
fixes readme.md changes package json to separate the original package…
…aluates to false.
…u00A0 as it was altering the word-wrap behavior in an undesired way.
… makes it easier to initialize and handle, and almost all operations on the value convert it to an array anyways. Now, when a new tag is added, the array is converted to a Set and back to an array, to remove duplicates.
CHANGELOG - Updates dependencies - Workflow: Basic Jest based tests & Travis integration - Add: TypeScript definitions - Add:: Constants for KeyCodes - Add: formatValue method that formats the getValue() content (note extracted by martinheidegger when debugging) - Add: consistent debug statements. - Code Cleanup.
Added missing changelog updates
add chilimatic improvements Thanks @martinheidegger!
ref is depecrated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the debug statements in RIEStatefulBase were using string template literal syntax, but missed using the tick instead of quote for it to work. Those should now output the intended debugging messages.
Also change the
!==comparator in RIEStatefulBase to!=to determine whether or not the value of the element had changed. This prevents an unnecessary update function call when the values are the same, just one a number and the other a string.