New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix DataSetImplements such that we can use functools.reduce again #221

Merged

nanne-aben merged 1 commit into main from hotfix-dataset-implements

Nov 8, 2023

Collaborator

nanne-aben commented Nov 8, 2023 •

edited

Loading

In the current master, the following code results in linting errors:

functools.reduce(
    DataSet.unionByName,
    [create_empty_dataset(spark, A), create_empty_dataset(spark, A)],
)

This is at odds with earlier versions of typedspark. This PR fixes the behaviour so that it's consistent with earlier versions.


          fix DataSetImplements such that we can use functools.reduce again

4b16ffe

nanne-aben merged commit ed8cd15 into main

4 checks passed

nanne-aben deleted the hotfix-dataset-implements branch

November 8, 2023 12:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet