Feature/schema property dataset #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanne-aben
reviewed
Aug 8, 2023
| @@ -87,7 +87,7 @@ def _add_schema_metadata(self) -> None: | |||
| self.schema[field.name].metadata = field.metadata | |||
|
|
|||
| @property | |||
| def typedspark_schema(self) -> T: | |||
| def typedspark_schema(self) -> Type[T]: | |||
| """Returns the ``Schema`` of the ``DataSet``.""" | |||
| return self._schema_annotations # type: ignore | |||
There was a problem hiding this comment.
Can we remove the type: ignore now too?
There was a problem hiding this comment.
Nope:
/Users/markromme/Documents/kaiko/clones/typedspark/typedspark/_core/dataset.py:92:16 - error: Expression of type "type[Schema]" cannot be assigned to return type "type[T@DataSet]"
Type "type[Schema]" cannot be assigned to type "type[T@DataSet]" (reportGeneralTypeIssues)```There was a problem hiding this comment.
Which is very odd as T@DataSet is a reference of the Schema
There was a problem hiding this comment.
Ugh... Well, at least it's the right type now!
nanne-aben
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be the right output type.