Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include docstrings in schemas - improved readibility #136

Merged

Conversation

jana-starkova
Copy link
Collaborator

fixes comments from #133 (review)

@jana-starkova jana-starkova marked this pull request as draft August 2, 2023 12:29
Copy link
Collaborator

@nanne-aben nanne-aben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Added minor comments for readability.

typedspark/_schema/get_schema_definition.py Outdated Show resolved Hide resolved
typedspark/_schema/get_schema_definition.py Show resolved Hide resolved
typedspark/_schema/get_schema_definition.py Outdated Show resolved Hide resolved
typedspark/_schema/get_schema_definition.py Outdated Show resolved Hide resolved
@jana-starkova jana-starkova marked this pull request as ready for review August 2, 2023 13:04
nanne-aben
nanne-aben previously approved these changes Aug 2, 2023
Copy link
Collaborator

@nanne-aben nanne-aben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you swap _extract_comment() and _create_typehint_and_comment()? I see I listed them the wrong way around in my comment. Otherwise LGTM!

@jana-starkova jana-starkova merged commit 3c4be6e into kaiko-ai:main Aug 2, 2023
3 checks passed
@jana-starkova jana-starkova deleted the include_docstrings_in_schemas branch August 2, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants