Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/search place by tag1 #16

Merged
merged 22 commits into from
Aug 24, 2023
Merged

Feat/search place by tag1 #16

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
f0b51e7
refactor: 리뷰 조회 응답에 멤버 profile 추가
SonMinGyu Aug 16, 2023
bd92297
feat: 태그로 장소 검색하는 기능 구현
SonMinGyu Aug 16, 2023
d5e61f2
test: 태그들로 장소 조회 인수 테스트 구현
SonMinGyu Aug 16, 2023
abfb4f8
refactor: 장소 응답에 태그 보내도록 리팩토링
SonMinGyu Aug 16, 2023
7f77798
refactor: 장소 조회 응답에 관련된 태그 같이 보내도록 리팩토링
SonMinGyu Aug 16, 2023
921a1e7
refactor: place 관련 review 조회 시 reviewTag join 추가
SonMinGyu Aug 16, 2023
9a7bc2f
refactor: review 조회 시 이미지 응답하도록 리팩토링
SonMinGyu Aug 16, 2023
42fcea7
refactor: 리뷰 작성 시 이미지 필수 조건 수정
SonMinGyu Aug 16, 2023
c3abf66
feat: 장소 등록 시 이미지 존재여부 판단 로직 추가
SonMinGyu Aug 16, 2023
8429465
refactor: 리뷰 응답에 장소 이름 추가
SonMinGyu Aug 16, 2023
b737711
test: ReviewAcceptanceTest 수정
SonMinGyu Aug 16, 2023
f761488
test: test오류 수정
SonMinGyu Aug 16, 2023
56b81b3
test: StudyRecordAcceptanceTest 수정
SonMinGyu Aug 16, 2023
81d0203
feat: StudyRecord 이미지 존재 여부 검증 로직 추가
SonMinGyu Aug 16, 2023
191bb97
test: PlaceAcceptanceTest 수정
SonMinGyu Aug 16, 2023
d1c00a2
test: StudyRecordServiceTest 수정
SonMinGyu Aug 16, 2023
d0c9a62
refactor: studyrecord 응답 시 image 보내주도록 리팩토링
SonMinGyu Aug 16, 2023
c6db02d
refactor: 코드 리뷰 사항 수정
SonMinGyu Aug 17, 2023
e26c46e
refactor: 코드 리뷰 내용 반영
SonMinGyu Aug 21, 2023
04dafa0
refactor: 코드 리뷰 사항 반영
SonMinGyu Aug 22, 2023
5c53d26
chore: jpa hibernate ddl-auto 속성 변경
SonMinGyu Aug 22, 2023
fc7fa46
chore: ddl-auto 수정
SonMinGyu Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/resources/application-develop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spring:
open-in-view: false
show-sql: true
hibernate:
ddl-auto: create
ddl-auto: update

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

운영환경에 올리면서 변경하게 된 걸까요?
update의 경우 잘 사용하지 않는 옵션입니다. 서비스 운영에서 문제가 되는 코드를 배포하는 경우는 허다한데, 그럴 경우 운영중인 원본 DB 테이블에 치명적인 영향을 끼칠 수 있어서 그래요.
운영이라면 좀 더 보수적으로 접근해서 none이나 validate 옵션을 주로 사용하고 있어요.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 확인해서 수정했습니다!

redis:
host: localhost
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/application-prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spring:
open-in-view: false
show-sql: true
hibernate:
ddl-auto: create
ddl-auto: update

redis:
host: localhost
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ spring:
open-in-view: false
show-sql: true
hibernate:
ddl-auto: create
ddl-auto: update

redis:
host: localhost
Expand Down
Loading