Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get_coordinator function in group subscriber v2 #608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add get_coordinator function in group subscriber v2 #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/brod_group_subscriber_v2.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
, start_link/1
, stop/1
, get_workers/1
, get_coordinator/1
]).

%% brod_group_coordinator callbacks
Expand Down Expand Up @@ -208,6 +209,15 @@ get_workers(Pid) ->
get_workers(Pid, Timeout) ->
gen_server:call(Pid, get_workers, Timeout).

%% @doc Returns the group coordinator PID.
-spec get_coordinator(pid()) -> pid() | undefined.
get_coordinator(Pid) ->
get_coordinator(Pid, infinity).

-spec get_coordinator(pid(), timeout()) -> pid() | undefined.
get_coordinator(Pid, Timeout) ->
gen_server:call(Pid, get_coordinator, Timeout).

%%%===================================================================
%%% group_coordinator callbacks
%%%===================================================================
Expand Down Expand Up @@ -315,6 +325,8 @@ handle_call({assign_partitions, Members, TopicPartitionList}, _From, State) ->
{reply, Reply, State};
handle_call(get_workers, _From, State = #state{workers = Workers}) ->
{reply, Workers, State};
handle_call(get_coordinator, _From, State = #state{coordinator = Coordinator}) ->
{reply, Coordinator, State};
handle_call(Call, _From, State) ->
{reply, {error, {unknown_call, Call}}, State}.

Expand Down
26 changes: 26 additions & 0 deletions test/brod_group_subscriber_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
, t_consumer_crash/1
, t_assign_partitions_handles_updating_state/1
, t_get_workers/1
, t_get_coordinator/1
, v2_coordinator_crash/1
, v2_consumer_cleanup/1
, v2_subscriber_shutdown/1
Expand Down Expand Up @@ -97,6 +98,7 @@ groups() ->
, t_async_commit
, t_assign_partitions_handles_updating_state
, t_get_workers
, t_get_coordinator
, v2_coordinator_crash
, v2_consumer_cleanup
, v2_subscriber_shutdown
Expand Down Expand Up @@ -308,6 +310,30 @@ t_get_workers(Config) when is_list(Config) ->
ok
end.

t_get_coordinator(Config) when is_list(Config) ->
case ?config(behavior) of
brod_group_subscriber_v2 ->
%% only present in v2
InitArgs = #{async_ack => true},
Topic = ?topic,
?check_trace(
#{ timeout => 10000 },
%% Run stage:
begin
{ok, SubscriberPid} = start_subscriber(?group_id, Config, [Topic], InitArgs),
ct:sleep(2000),
brod_group_subscriber_v2:get_coordinator(SubscriberPid)
end,
%% Check stage:
fun(Coordinator, _Trace) ->
ct:pal("result: ~p", [Coordinator]),
?assert(is_pid(Coordinator)),
ok
end);
_ ->
ok
end.

t_consumer_crash(Config) when is_list(Config) ->
%% use consumer managed offset commit behaviour
%% so we can control where to start fetching messages from
Expand Down