Skip to content

Commit

Permalink
Bump Ubuntu action runner to 24.04 (#541)
Browse files Browse the repository at this point in the history
* Bump Ubuntu action runner to 24.04

* Add workaround to install libyaml because of the patch is not yet deployed

actions/runner-images@a9fed55

* This step should be done before setup-ruby

* Specify setup-ruby versions

* I don't know why appeared only in 3.2

* Consider if added macos and windows runner here
  • Loading branch information
kachick authored May 20, 2024
1 parent 4c4f9e1 commit 9f21289
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-nix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
fail-fast: false
matrix:
os:
- ubuntu-latest
- ubuntu-24.04
- macos-14
runs-on: ${{ matrix.os }}
timeout-minutes: 30
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,18 @@ jobs:
# Syntax https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs
matrix:
# macos is covered in nix ci
os: ['ubuntu-latest']
os: ['ubuntu-24.04']
# Due to https://github.com/actions/runner/issues/849, we have to use quotes for 'n.0'
ruby: ['head', '3.3', '3.2']
runs-on: ${{ matrix.os }}
steps:
# libyaml is needed for psych, see https://github.com/actions/runner-images/issues/9895
# GitHub installs libyaml-dev in latest runners, but often dropped in new runners.
- name: Install libyaml
if: startsWith(matrix.os, 'ubuntu-') && matrix.ruby == '3.2'
run: sudo apt-get install --no-install-recommends --assume-yes libyaml-dev
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
- uses: ruby/setup-ruby@7dc18ff0ca6e3630d3f29d2a85ebf6cc27ae9d6c # v1.177.0
env:
# https://github.com/kachick/ruby-ulid/blob/104834846baf5caa1e8536a11c43acdd56fc849c/CONTRIBUTING.md#adding-dependencies-for-this-gem
BUNDLE_WITHOUT: development
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ on:
jobs:
analyze:
name: Analyze
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
permissions:
actions: read
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dependency-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ permissions:
jobs:
dependency-review:
timeout-minutes: 15
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: 'Checkout Repository'
uses: actions/checkout@v4
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,17 @@ on:
jobs:
rubocop:
timeout-minutes: 15
runs-on: 'ubuntu-latest'
runs-on: 'ubuntu-24.04'
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
- uses: ruby/setup-ruby@7dc18ff0ca6e3630d3f29d2a85ebf6cc27ae9d6c # v1.177.0
with:
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- run: bundle exec rake rubocop

dprint:
timeout-minutes: 15
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: dprint/[email protected]
Expand All @@ -30,7 +30,7 @@ jobs:

typos:
timeout-minutes: 15
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: crate-ci/[email protected] # selfup { "regex": "\\d\\.\\d+\\.\\d+", "script": "typos --version | cut -d ' ' -f 2" }
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/merge-bot-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ permissions:
jobs:
dependabot:
timeout-minutes: 30
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: ${{ github.actor == 'dependabot[bot]' }}
steps:
- name: Dependabot metadata
Expand Down Expand Up @@ -40,7 +40,7 @@ jobs:
# Changing in all personal repository is annoy task for me. Even if using terrafform, getting mandatory CI names in each repo is too annoy!
renovate:
timeout-minutes: 30
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: ${{ github.actor == 'renovate[bot]' }}
steps:
- name: Wait other jobs
Expand All @@ -57,7 +57,7 @@ jobs:
# https://github.com/kachick/anylang-template/issues/51
selfup-runner:
timeout-minutes: 30
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: ${{ github.actor == 'selfup-runner[bot]' }}
steps:
- name: Wait other jobs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
name: Build and deploy YARD
steps:
- uses: kachick/deploy-yard-to-pages@v1
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/signature.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,19 @@ on:
jobs:
rbs:
timeout-minutes: 15
runs-on: 'ubuntu-latest'
runs-on: 'ubuntu-24.04'
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
- uses: ruby/setup-ruby@7dc18ff0ca6e3630d3f29d2a85ebf6cc27ae9d6c # v1.177.0
with:
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- run: bundle exec rake rbs
yard:
timeout-minutes: 15
runs-on: 'ubuntu-latest'
runs-on: 'ubuntu-24.04'
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
- uses: ruby/setup-ruby@7dc18ff0ca6e3630d3f29d2a85ebf6cc27ae9d6c # v1.177.0
with:
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- run: bundle exec rake signature:validate_yard

0 comments on commit 9f21289

Please sign in to comment.