Unmounted RWO PVCs without NodeAffinity on the PV should be backed up as well #980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I did realize that k8up was skipping one of my volumes because it was not bound and had no NodeAffinity on its PVC. I believe this is wrong behavior, since RWO Volumes without NodeAffinity can be used on any Node. In my case I have RWO PVCs based on Rook Ceph, they have RWO semantics but have no restriction on the Node.
This change adds an integration test which describes the expected behavior and changes the code so that these volumes are included.
Checklist
For Code changes
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog
area:operator
charts/
directory.For Helm Chart changes
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog
area:chart
chart:k8up
make chart-docs