Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmounted RWO PVCs without NodeAffinity on the PV should be backed up as well #980

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

johbo
Copy link
Contributor

@johbo johbo commented Jun 13, 2024

Summary

I did realize that k8up was skipping one of my volumes because it was not bound and had no NodeAffinity on its PVC. I believe this is wrong behavior, since RWO Volumes without NodeAffinity can be used on any Node. In my case I have RWO PVCs based on Rook Ceph, they have RWO semantics but have no restriction on the Node.

This change adds an integration test which describes the expected behavior and changes the code so that these volumes are included.

Checklist

For Code changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:operator
  • Commits are signed off
  • Link this PR to related issues
  • I have not made any changes in the charts/ directory.

For Helm Chart changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:chart
  • PR contains the chart label, e.g. chart:k8up
  • Commits are signed off
  • Variables are documented in the values.yaml using the format required by Helm-Docs.
  • Chart Version bumped if immediate release after merging is planned
  • I have run make chart-docs
  • Link this PR to related code release or other issues.

Signed-off-by: Johannes Bornhold <[email protected]>
@johbo johbo requested a review from a team as a code owner June 13, 2024 20:27
@johbo johbo requested review from Kidswiss and lieneluksika and removed request for a team June 13, 2024 20:27
@johbo johbo force-pushed the unmounted-rwo-volume branch from 5853f9d to fa178ec Compare June 13, 2024 20:29
@Kidswiss Kidswiss added enhancement New feature or request area:operator labels Jun 17, 2024
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it makes sense to include these as well.

@Kidswiss Kidswiss merged commit debabf3 into k8up-io:master Jun 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:operator enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants