Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Helm - Grafana Dashboard #967

Merged
merged 1 commit into from
May 28, 2024

Conversation

SchoolGuy
Copy link
Contributor

@SchoolGuy SchoolGuy commented May 9, 2024

Summary

This PR adds a Grafana dashboard that exposes the metrics that both the operator and the pushgateway are exposing.

This is related (but not fixing) #860

Checklist

For Code changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:operator
  • Link this PR to related issues
  • I have not made any changes in the charts/ directory.

For Helm Chart changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:chart
  • PR contains the chart label, e.g. chart:k8up
  • Variables are documented in the values.yaml using the format required by Helm-Docs.
  • Chart Version bumped if immediate release after merging is planned
  • I have run make chart-docs
  • Link this PR to related code release or other issues.

@SchoolGuy SchoolGuy requested a review from a team as a code owner May 9, 2024 10:39
@SchoolGuy SchoolGuy requested review from zugao and lieneluksika and removed request for a team May 9, 2024 10:39
@SchoolGuy SchoolGuy force-pushed the add-grafana-dashboard branch from fb37dcb to 4110662 Compare May 9, 2024 10:45
@zugao zugao requested a review from Kidswiss May 10, 2024 06:41
@Kidswiss
Copy link
Contributor

@SchoolGuy

Looks like helm is not happy with the template :/ It tries to interpret some grafana dashboard variables as helm variables. You probably have to add some sort of escaping to prevent that.

@TheBigLee TheBigLee self-requested a review May 27, 2024 14:48
@TheBigLee TheBigLee force-pushed the add-grafana-dashboard branch 4 times, most recently from 0c6eb81 to 5042b52 Compare May 28, 2024 08:33
@TheBigLee TheBigLee force-pushed the add-grafana-dashboard branch from 5042b52 to a937ad7 Compare May 28, 2024 08:42
Signed-off-by: Enno Gotthold <[email protected]>
Signed-off-by: Nicolas Bigler <[email protected]>
@TheBigLee TheBigLee force-pushed the add-grafana-dashboard branch from a937ad7 to c0efc71 Compare May 28, 2024 09:37
@TheBigLee TheBigLee merged commit d996d16 into k8up-io:master May 28, 2024
7 checks passed
eunames added a commit to eunames/k8up that referenced this pull request Jun 6, 2024
commit 1e7871c
Merge: d996d16 0f1228f
Author: Bigli <[email protected]>
Date:   Tue May 28 13:17:19 2024 +0200

    Merge pull request k8up-io#974 from k8up-io/gh/pr_template_co_sign

    Adjust the PR template to include signing off the commits

commit 0f1228f
Author: Nicolas Bigler <[email protected]>
Date:   Tue May 28 12:44:20 2024 +0200

    Adjust the PR template to include signing off the commits

    Signed-off-by: Nicolas Bigler <[email protected]>

commit d996d16
Merge: 0b29883 c0efc71
Author: Bigli <[email protected]>
Date:   Tue May 28 12:41:08 2024 +0200

    Merge pull request k8up-io#967 from SchoolGuy/add-grafana-dashboard

    feat: Helm - Grafana Dashboard

commit c0efc71
Author: Enno Gotthold <[email protected]>
Date:   Thu May 9 12:35:41 2024 +0200

    [ADD] Helm - Grafana Dashboard

    Signed-off-by: Enno Gotthold <[email protected]>
    Signed-off-by: Nicolas Bigler <[email protected]>

commit 0b29883
Merge: 60e75b6 f6648dd
Author: Bigli <[email protected]>
Date:   Tue May 28 10:18:14 2024 +0200

    Merge pull request k8up-io#971 from k8up-io/tutorial/update_crd_version

    Update the tutorial to the latest k8up version

commit f6648dd
Author: Nicolas Bigler <[email protected]>
Date:   Mon May 27 15:31:27 2024 +0200

    Update the tutorial to the latest k8up version

    Signed-off-by: Nicolas Bigler <[email protected]>

commit 60e75b6
Merge: 212a033 162e16b
Author: Kidswiss <[email protected]>
Date:   Wed May 15 10:20:29 2024 +0200

    Merge pull request k8up-io#969 from k8up-io/bump_chart

    Bump K8up version

commit 162e16b
Author: Simon Beck <[email protected]>
Date:   Wed May 15 09:45:16 2024 +0200

    Bump K8up version

    Signed-off-by: Simon Beck <[email protected]>

commit 212a033
Merge: 2ddb6ee c8e9202
Author: Kidswiss <[email protected]>
Date:   Wed May 15 09:36:03 2024 +0200

    Merge pull request k8up-io#968 from k8up-io/add/pod_spec

    Add full podSpec to all job types

commit c8e9202
Author: Simon Beck <[email protected]>
Date:   Wed May 15 09:04:58 2024 +0200

    Remove unnecessary RBAC

    Signed-off-by: Simon Beck <[email protected]>

commit d21f019
Author: Simon Beck <[email protected]>
Date:   Tue May 14 16:01:26 2024 +0200

    Correctly flag test for integration

    Signed-off-by: Simon Beck <[email protected]>

commit edea9f6
Author: Simon Beck <[email protected]>
Date:   Tue May 14 15:29:02 2024 +0200

    Add make test to actions

    Signed-off-by: Simon Beck <[email protected]>

commit 21494ca
Author: Simon Beck <[email protected]>
Date:   Mon May 13 13:26:56 2024 +0200

    Add docs

    Signed-off-by: Simon Beck <[email protected]>

commit 2666a12
Author: Simon Beck <[email protected]>
Date:   Mon May 13 12:50:07 2024 +0200

    Fix using the index to delay execution

    It did not actually do a staggered delay for each instance.

    Signed-off-by: Simon Beck <[email protected]>

commit dd9f657
Author: Simon Beck <[email protected]>
Date:   Mon May 13 12:49:52 2024 +0200

    Add full podSpec to all job types

    With this commit it's now possible to specify a full podSpec for each
    job type available.

    Signed-off-by: Simon Beck <[email protected]>

commit 2ddb6ee
Merge: 5ab0be4 15f78ac
Author: Kidswiss <[email protected]>
Date:   Tue Apr 30 15:34:54 2024 +0200

    Merge pull request k8up-io#963 from k8up-io/bump-chart

    Bump versions in the chart

commit 15f78ac
Author: Simon Beck <[email protected]>
Date:   Tue Apr 30 15:10:27 2024 +0200

    Bump versions in the chart

    Signed-off-by: Simon Beck <[email protected]>

commit 5ab0be4
Merge: 5d67b16 51b7fd7
Author: Kidswiss <[email protected]>
Date:   Tue Apr 30 14:47:07 2024 +0200

    Merge pull request k8up-io#962 from amghazanfari/master

    bug: Add operator as mandatory argument

commit 51b7fd7
Author: Amir M. Ghazanfari <[email protected]>
Date:   Sun Apr 28 12:37:15 2024 +0330

    Add operator as mandatory argument

    Signed-off-by:  amghazanfari <[email protected]>
    Signed-off-by: Amir Ghazanfari <[email protected]>

commit 5d67b16
Merge: 2971c49 ccd6bce
Author: Kidswiss <[email protected]>
Date:   Fri Apr 12 11:12:03 2024 +0200

    Merge pull request k8up-io#954 from M0NsTeRRR/master

    [enhancement] add support for dual stack clusters

commit 2971c49
Merge: 1088118 80b2ddd
Author: Kidswiss <[email protected]>
Date:   Fri Apr 12 10:22:25 2024 +0200

    Merge pull request k8up-io#949 from poyaz/feature/custom-tls

    [enhancement] Adding new feature for supporting self-signed certificate

commit 80b2ddd
Author: poyaz <[email protected]>
Date:   Thu Apr 11 17:33:31 2024 +0330

    [ADD] Add integration test for TLS and Mutual TLS options

    Signed-off-by: poyaz <[email protected]>

commit ad78959
Author: poyaz <[email protected]>
Date:   Thu Apr 11 17:32:40 2024 +0330

    [FIX] Fix execute ps for alpine and BusyBox

    Signed-off-by: poyaz <[email protected]>

commit 1fc3b16
Author: poyaz <[email protected]>
Date:   Thu Apr 11 17:32:05 2024 +0330

    [UPDATE] Rename argument "--varDir" to "-varDir"

    Signed-off-by: poyaz <[email protected]>

commit df889cb
Author: poyaz <[email protected]>
Date:   Thu Apr 11 17:14:02 2024 +0330

    [UPDATE] Add unit test for utils file and refactoring ZeroLen function

    Signed-off-by: poyaz <[email protected]>

commit 22de53e
Author: poyaz <[email protected]>
Date:   Thu Apr 11 00:56:30 2024 +0330

    [DELETE] Delete e2e test self signed tls becuase it has too many test case and spend too much time

    Move restore and archive test case to two separated files

    Signed-off-by: poyaz <[email protected]>

commit 7d121ff
Author: poyaz <[email protected]>
Date:   Thu Apr 11 00:53:42 2024 +0330

    [ADD] Add two e2e test for restore and archive

    Signed-off-by: poyaz <[email protected]>

commit dc9f803
Author: poyaz <[email protected]>
Date:   Thu Apr 11 00:52:56 2024 +0330

    [ADD] Add cmctl command for check cert-manager is ready

    Signed-off-by: poyaz <[email protected]>

commit 0acef98
Author: poyaz <[email protected]>
Date:   Thu Apr 11 00:32:34 2024 +0330

    [UPDATE] Refactoring code for duplciate fucntions in operators

    These functions is created in utils:
    - AppendTLSOptionsArgs: for generate env for backend and restore specs
    - AttachTLSVolumes: for create volumes for pods
    AttachTLSVolumeMounts: for create volumeMount for backend and restore specs

    Signed-off-by: poyaz <[email protected]>

commit b59589a
Author: poyaz <[email protected]>
Date:   Thu Apr 11 00:30:11 2024 +0330

    [UPDATE] Update documents because of changing options to tlsOptions

    Signed-off-by: poyaz <[email protected]>

commit 01cb120
Author: Pooya Azarpour <[email protected]>
Date:   Mon Apr 8 14:21:24 2024 +0330

    [CHANGE] Rename options to tlsOptions

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 9b4216a
Author: Pooya Azarpour <[email protected]>
Date:   Mon Apr 8 11:01:50 2024 +0330

    [DELETE] Delete unnecessary error param in setupArgs function

    Signed-off-by: Pooya Azarpour <[email protected]>

commit ccd6bce
Author: Ludovic Ortega <[email protected]>
Date:   Sat Apr 6 17:59:17 2024 +0200

    feat: add support for dual stack clusters

    Signed-off-by: Ludovic Ortega <[email protected]>

commit d1319f0
Author: Pooya Azarpour <[email protected]>
Date:   Sat Apr 6 13:43:25 2024 +0330

    [FIX] Fix typo and document's grammers

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 8713c81
Author: Pooya Azarpour <[email protected]>
Date:   Sat Apr 6 13:40:33 2024 +0330

    [UPDATE] Formatting go files to old style (Remove idea customziation formatter)

    Signed-off-by: Pooya Azarpour <[email protected]>

commit f6b0f12
Author: Pooya Azarpour <[email protected]>
Date:   Sat Apr 6 11:20:33 2024 +0330

    [DELETE] Delete command "sleep 3"

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 1088118
Merge: b16b4bf 29cdb0a
Author: Tobias Brunner <[email protected]>
Date:   Thu Apr 4 08:36:45 2024 +0200

    Merge pull request k8up-io#952 from halil-bugol/patch-1

    Add Kubezy as adopter

commit 29cdb0a
Author: Halil İbrahim BUGÖL <[email protected]>
Date:   Thu Apr 4 00:53:48 2024 +0300

    Update ADOPTERS.md

    Signed-off-by: Halil Bugol <[email protected]>
    Signed-off-by: Halil İbrahim BUGÖL <[email protected]>

commit 9f776fe
Author: poyaz <[email protected]>
Date:   Sat Mar 23 17:05:19 2024 +0330

    [FIX] Fix test for expected args

    Signed-off-by: poyaz <[email protected]>

commit 295e5bf
Author: poyaz <[email protected]>
Date:   Sat Mar 23 16:55:12 2024 +0330

    [ADD] Adding variable GO_EXEC in Makefile to choose different versions of Golang

    Signed-off-by: poyaz <[email protected]>

commit c668b25
Author: poyaz <[email protected]>
Date:   Sat Mar 23 16:53:54 2024 +0330

    [FIX] Fixing integration test for restic s3. Missing CaCert arguments

    Signed-off-by: poyaz <[email protected]>

commit da60a0b
Author: poyaz <[email protected]>
Date:   Sat Mar 23 15:03:13 2024 +0330

    ADD] Adding e2e test over using env for TLS and mTls

    Also fixing bug in get lentgh of archive object in minio-mc

    Signed-off-by: poyaz <[email protected]>

commit 41825f9
Author: poyaz <[email protected]>
Date:   Sat Mar 23 15:03:06 2024 +0330

    [ADD] Adding e2e definitaions for using env for TLS and mTls

    Signed-off-by: poyaz <[email protected]>

commit bd2c880
Author: poyaz <[email protected]>
Date:   Sat Mar 23 15:01:04 2024 +0330

    [UPDATE] Update cert-manager to v1.14.4

    Signed-off-by: poyaz <[email protected]>

commit 6b659b8
Author: poyaz <[email protected]>
Date:   Sat Mar 23 13:14:10 2024 +0330

    [UPDATE] Update api-refrence according to supporting volume, volumeMount, and options

    Signed-off-by: poyaz <[email protected]>

commit b2b83e1
Author: poyaz <[email protected]>
Date:   Sat Mar 23 13:12:30 2024 +0330

    [ADD] Adding document about how to use TLS and mTls in api refrence

    Signed-off-by: poyaz <[email protected]>

commit fe51211
Author: poyaz <[email protected]>
Date:   Sat Mar 23 13:12:03 2024 +0330

    [FIX] Removing unnecessary snipped tag (tag: <SNIP>)

    Signed-off-by: poyaz <[email protected]>

commit 800b819
Author: poyaz <[email protected]>
Date:   Sat Mar 23 13:10:27 2024 +0330

    [UPDATE] Update operator and restic cli help according to new values is added

    Signed-off-by: poyaz <[email protected]>

commit 11f0945
Author: poyaz <[email protected]>
Date:   Sat Mar 23 13:09:48 2024 +0330

    [ADD] Adding RESTORE_CA_CERT_FILE, RESTORE_CA_CERT_FILE, RESTORE_CLIENT_KEY_FILE env instead of filling TLS and mTls options in restore method

    Signed-off-by: poyaz <[email protected]>

commit a9cf8fd
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:08:07 2024 +0330

    [FIX] Fixning problem in attach mode when failer happend in pod

    Signed-off-by: poyaz <[email protected]>

commit 97e03e0
Merge: 5270d54 b16b4bf
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:06:15 2024 +0330

    Merge remote-tracking branch 'upstream/master' into feature/custom-tls

    Signed-off-by: poyaz <[email protected]>

commit 5270d54
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:05:02 2024 +0330

    [ADD] Adding new e2e test for supporting self-signed issuer

    This test contains below sections:
    - Testing backup API for TLS and mTLS mode
    - Testing restore API in pvc for TLS and mTLS mode
    - Testing restore API in S3 for TLS and mTLS mode
    - Testing archive API in S3 for TLS and mTLS mode
    - Testin check API for TLS and mTLS mode

    Signed-off-by: poyaz <[email protected]>

commit f391110
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:04:44 2024 +0330

    [ADD] Add some fucntions for checking e2e test

    These fucntions add:
    - Adding "mc" function for using minio client for using download files, remove buckets, get list of files
    - Adding "given_a_clean_archive" function for clear archive bucket
    - Adding "given_a_subject_dl" function for apply deployment for checking last backup when restore in S3
    - Adding "give_self_signed_issuer" function for create self-signed issuer
    - Adding "expect_dl_file_in_container" function for checking is last backup was uploaded in S3 is okay

    Also fix some bugs:
    - Fixing empty output when get last dump of snapshot - becuase of syncing and storing file in disk, fetching last dump is took and the output of "run restic dump latest" is empty
    - Adding sleep before running restic and mc

    Signed-off-by: poyaz <[email protected]>

commit 2af7fd6
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:04:23 2024 +0330

    [ADD] Adding new resource definitions for e2e test in TLS and mTls mode

    These definitions contain below:
    - Adding archive
    Adding restore
    Adding backup
    Adding nginx for use reverse proxy in TLS and mTls mode
    Adding cert-manager for genrate self-signed issuer

    Signed-off-by: poyaz <[email protected]>

commit a56d465
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:03:58 2024 +0330

    [UPDATE] Generating new crd according to adding VolumeMounts to BackendSpec and RestoreMethodSpec

    Signed-off-by: poyaz <[email protected]>

commit ece84c7
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:03:46 2024 +0330

    [UPDATE] Addin VolumeMounts to BackendSpec and RestoreMethod

    Change:
    - Removing VolumeMounts from S3Spec and RestServerSpec in BackendSpec. Adding to BackendSpec (File: v1/backend.go)
    - Adding VolumeMounts to RestoreMethod (File: v1/restore_types.go)

    Signed-off-by: poyaz <[email protected]>

commit c42e748
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:02:47 2024 +0330

    [UPDATE] Generating new crd according to adding VolumeMounts to BackendSpec and RestoreMethodSpec

    Also these changes appends:
    - Running linter
    - Fixing check null pointer error if BackendSpec or Volume of Spec is null
    - Fixing check add duplicate VolumeMount in archive and restore API
    - Refactoring setupArgs

    Signed-off-by: poyaz <[email protected]>

commit a0f78d7
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:01:14 2024 +0330

    [ADD] Adding container volumes when they are mounting

    Signed-off-by: poyaz <[email protected]>

commit e2622c6
Author: Pooya Azarpour <[email protected]>
Date:   Mon Mar 18 19:45:22 2024 +0330

    [ADD] Supporting self certificate authority and mTls when using S3 object storage

    Signed-off-by: Pooya Azarpour <[email protected]>

commit e13ba45
Author: Pooya Azarpour <[email protected]>
Date:   Mon Mar 18 19:43:39 2024 +0330

    [ADD] Add vardir command option for mount emptyDir in pod

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 8eb0703
Author: Pooya Azarpour <[email protected]>
Date:   Mon Mar 18 19:41:40 2024 +0330

    [ADD] Add Volume for using secret or configmap in k8s, Add VolumeMounts for mount volume, Add BackendOpts for using custom options in k8up or restic

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 2ea688a
Author: Pooya Azarpour <[email protected]>
Date:   Mon Mar 18 19:39:05 2024 +0330

    [ADD] Add GO_EXEC variable for using multiply version of go binary

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 43f750c
Author: Pooya Azarpour <[email protected]>
Date:   Mon Mar 18 19:37:59 2024 +0330

    [ADD] Ignoring vagrant dir in git

    Signed-off-by: Pooya Azarpour <[email protected]>
eunames added a commit to eunames/k8up that referenced this pull request Jun 6, 2024
commit 1e7871c
Merge: d996d16 0f1228f
Author: Bigli <[email protected]>
Date:   Tue May 28 13:17:19 2024 +0200

    Merge pull request k8up-io#974 from k8up-io/gh/pr_template_co_sign

    Adjust the PR template to include signing off the commits

commit 0f1228f
Author: Nicolas Bigler <[email protected]>
Date:   Tue May 28 12:44:20 2024 +0200

    Adjust the PR template to include signing off the commits

    Signed-off-by: Nicolas Bigler <[email protected]>

commit d996d16
Merge: 0b29883 c0efc71
Author: Bigli <[email protected]>
Date:   Tue May 28 12:41:08 2024 +0200

    Merge pull request k8up-io#967 from SchoolGuy/add-grafana-dashboard

    feat: Helm - Grafana Dashboard

commit c0efc71
Author: Enno Gotthold <[email protected]>
Date:   Thu May 9 12:35:41 2024 +0200

    [ADD] Helm - Grafana Dashboard

    Signed-off-by: Enno Gotthold <[email protected]>
    Signed-off-by: Nicolas Bigler <[email protected]>

commit 0b29883
Merge: 60e75b6 f6648dd
Author: Bigli <[email protected]>
Date:   Tue May 28 10:18:14 2024 +0200

    Merge pull request k8up-io#971 from k8up-io/tutorial/update_crd_version

    Update the tutorial to the latest k8up version

commit f6648dd
Author: Nicolas Bigler <[email protected]>
Date:   Mon May 27 15:31:27 2024 +0200

    Update the tutorial to the latest k8up version

    Signed-off-by: Nicolas Bigler <[email protected]>

commit 60e75b6
Merge: 212a033 162e16b
Author: Kidswiss <[email protected]>
Date:   Wed May 15 10:20:29 2024 +0200

    Merge pull request k8up-io#969 from k8up-io/bump_chart

    Bump K8up version

commit 162e16b
Author: Simon Beck <[email protected]>
Date:   Wed May 15 09:45:16 2024 +0200

    Bump K8up version

    Signed-off-by: Simon Beck <[email protected]>

commit 212a033
Merge: 2ddb6ee c8e9202
Author: Kidswiss <[email protected]>
Date:   Wed May 15 09:36:03 2024 +0200

    Merge pull request k8up-io#968 from k8up-io/add/pod_spec

    Add full podSpec to all job types

commit c8e9202
Author: Simon Beck <[email protected]>
Date:   Wed May 15 09:04:58 2024 +0200

    Remove unnecessary RBAC

    Signed-off-by: Simon Beck <[email protected]>

commit d21f019
Author: Simon Beck <[email protected]>
Date:   Tue May 14 16:01:26 2024 +0200

    Correctly flag test for integration

    Signed-off-by: Simon Beck <[email protected]>

commit edea9f6
Author: Simon Beck <[email protected]>
Date:   Tue May 14 15:29:02 2024 +0200

    Add make test to actions

    Signed-off-by: Simon Beck <[email protected]>

commit 21494ca
Author: Simon Beck <[email protected]>
Date:   Mon May 13 13:26:56 2024 +0200

    Add docs

    Signed-off-by: Simon Beck <[email protected]>

commit 2666a12
Author: Simon Beck <[email protected]>
Date:   Mon May 13 12:50:07 2024 +0200

    Fix using the index to delay execution

    It did not actually do a staggered delay for each instance.

    Signed-off-by: Simon Beck <[email protected]>

commit dd9f657
Author: Simon Beck <[email protected]>
Date:   Mon May 13 12:49:52 2024 +0200

    Add full podSpec to all job types

    With this commit it's now possible to specify a full podSpec for each
    job type available.

    Signed-off-by: Simon Beck <[email protected]>

commit 2ddb6ee
Merge: 5ab0be4 15f78ac
Author: Kidswiss <[email protected]>
Date:   Tue Apr 30 15:34:54 2024 +0200

    Merge pull request k8up-io#963 from k8up-io/bump-chart

    Bump versions in the chart

commit 15f78ac
Author: Simon Beck <[email protected]>
Date:   Tue Apr 30 15:10:27 2024 +0200

    Bump versions in the chart

    Signed-off-by: Simon Beck <[email protected]>

commit 5ab0be4
Merge: 5d67b16 51b7fd7
Author: Kidswiss <[email protected]>
Date:   Tue Apr 30 14:47:07 2024 +0200

    Merge pull request k8up-io#962 from amghazanfari/master

    bug: Add operator as mandatory argument

commit 51b7fd7
Author: Amir M. Ghazanfari <[email protected]>
Date:   Sun Apr 28 12:37:15 2024 +0330

    Add operator as mandatory argument

    Signed-off-by:  amghazanfari <[email protected]>
    Signed-off-by: Amir Ghazanfari <[email protected]>

commit 5d67b16
Merge: 2971c49 ccd6bce
Author: Kidswiss <[email protected]>
Date:   Fri Apr 12 11:12:03 2024 +0200

    Merge pull request k8up-io#954 from M0NsTeRRR/master

    [enhancement] add support for dual stack clusters

commit 2971c49
Merge: 1088118 80b2ddd
Author: Kidswiss <[email protected]>
Date:   Fri Apr 12 10:22:25 2024 +0200

    Merge pull request k8up-io#949 from poyaz/feature/custom-tls

    [enhancement] Adding new feature for supporting self-signed certificate

commit 80b2ddd
Author: poyaz <[email protected]>
Date:   Thu Apr 11 17:33:31 2024 +0330

    [ADD] Add integration test for TLS and Mutual TLS options

    Signed-off-by: poyaz <[email protected]>

commit ad78959
Author: poyaz <[email protected]>
Date:   Thu Apr 11 17:32:40 2024 +0330

    [FIX] Fix execute ps for alpine and BusyBox

    Signed-off-by: poyaz <[email protected]>

commit 1fc3b16
Author: poyaz <[email protected]>
Date:   Thu Apr 11 17:32:05 2024 +0330

    [UPDATE] Rename argument "--varDir" to "-varDir"

    Signed-off-by: poyaz <[email protected]>

commit df889cb
Author: poyaz <[email protected]>
Date:   Thu Apr 11 17:14:02 2024 +0330

    [UPDATE] Add unit test for utils file and refactoring ZeroLen function

    Signed-off-by: poyaz <[email protected]>

commit 22de53e
Author: poyaz <[email protected]>
Date:   Thu Apr 11 00:56:30 2024 +0330

    [DELETE] Delete e2e test self signed tls becuase it has too many test case and spend too much time

    Move restore and archive test case to two separated files

    Signed-off-by: poyaz <[email protected]>

commit 7d121ff
Author: poyaz <[email protected]>
Date:   Thu Apr 11 00:53:42 2024 +0330

    [ADD] Add two e2e test for restore and archive

    Signed-off-by: poyaz <[email protected]>

commit dc9f803
Author: poyaz <[email protected]>
Date:   Thu Apr 11 00:52:56 2024 +0330

    [ADD] Add cmctl command for check cert-manager is ready

    Signed-off-by: poyaz <[email protected]>

commit 0acef98
Author: poyaz <[email protected]>
Date:   Thu Apr 11 00:32:34 2024 +0330

    [UPDATE] Refactoring code for duplciate fucntions in operators

    These functions is created in utils:
    - AppendTLSOptionsArgs: for generate env for backend and restore specs
    - AttachTLSVolumes: for create volumes for pods
    AttachTLSVolumeMounts: for create volumeMount for backend and restore specs

    Signed-off-by: poyaz <[email protected]>

commit b59589a
Author: poyaz <[email protected]>
Date:   Thu Apr 11 00:30:11 2024 +0330

    [UPDATE] Update documents because of changing options to tlsOptions

    Signed-off-by: poyaz <[email protected]>

commit 01cb120
Author: Pooya Azarpour <[email protected]>
Date:   Mon Apr 8 14:21:24 2024 +0330

    [CHANGE] Rename options to tlsOptions

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 9b4216a
Author: Pooya Azarpour <[email protected]>
Date:   Mon Apr 8 11:01:50 2024 +0330

    [DELETE] Delete unnecessary error param in setupArgs function

    Signed-off-by: Pooya Azarpour <[email protected]>

commit ccd6bce
Author: Ludovic Ortega <[email protected]>
Date:   Sat Apr 6 17:59:17 2024 +0200

    feat: add support for dual stack clusters

    Signed-off-by: Ludovic Ortega <[email protected]>

commit d1319f0
Author: Pooya Azarpour <[email protected]>
Date:   Sat Apr 6 13:43:25 2024 +0330

    [FIX] Fix typo and document's grammers

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 8713c81
Author: Pooya Azarpour <[email protected]>
Date:   Sat Apr 6 13:40:33 2024 +0330

    [UPDATE] Formatting go files to old style (Remove idea customziation formatter)

    Signed-off-by: Pooya Azarpour <[email protected]>

commit f6b0f12
Author: Pooya Azarpour <[email protected]>
Date:   Sat Apr 6 11:20:33 2024 +0330

    [DELETE] Delete command "sleep 3"

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 1088118
Merge: b16b4bf 29cdb0a
Author: Tobias Brunner <[email protected]>
Date:   Thu Apr 4 08:36:45 2024 +0200

    Merge pull request k8up-io#952 from halil-bugol/patch-1

    Add Kubezy as adopter

commit 29cdb0a
Author: Halil İbrahim BUGÖL <[email protected]>
Date:   Thu Apr 4 00:53:48 2024 +0300

    Update ADOPTERS.md

    Signed-off-by: Halil Bugol <[email protected]>
    Signed-off-by: Halil İbrahim BUGÖL <[email protected]>

commit 9f776fe
Author: poyaz <[email protected]>
Date:   Sat Mar 23 17:05:19 2024 +0330

    [FIX] Fix test for expected args

    Signed-off-by: poyaz <[email protected]>

commit 295e5bf
Author: poyaz <[email protected]>
Date:   Sat Mar 23 16:55:12 2024 +0330

    [ADD] Adding variable GO_EXEC in Makefile to choose different versions of Golang

    Signed-off-by: poyaz <[email protected]>

commit c668b25
Author: poyaz <[email protected]>
Date:   Sat Mar 23 16:53:54 2024 +0330

    [FIX] Fixing integration test for restic s3. Missing CaCert arguments

    Signed-off-by: poyaz <[email protected]>

commit da60a0b
Author: poyaz <[email protected]>
Date:   Sat Mar 23 15:03:13 2024 +0330

    ADD] Adding e2e test over using env for TLS and mTls

    Also fixing bug in get lentgh of archive object in minio-mc

    Signed-off-by: poyaz <[email protected]>

commit 41825f9
Author: poyaz <[email protected]>
Date:   Sat Mar 23 15:03:06 2024 +0330

    [ADD] Adding e2e definitaions for using env for TLS and mTls

    Signed-off-by: poyaz <[email protected]>

commit bd2c880
Author: poyaz <[email protected]>
Date:   Sat Mar 23 15:01:04 2024 +0330

    [UPDATE] Update cert-manager to v1.14.4

    Signed-off-by: poyaz <[email protected]>

commit 6b659b8
Author: poyaz <[email protected]>
Date:   Sat Mar 23 13:14:10 2024 +0330

    [UPDATE] Update api-refrence according to supporting volume, volumeMount, and options

    Signed-off-by: poyaz <[email protected]>

commit b2b83e1
Author: poyaz <[email protected]>
Date:   Sat Mar 23 13:12:30 2024 +0330

    [ADD] Adding document about how to use TLS and mTls in api refrence

    Signed-off-by: poyaz <[email protected]>

commit fe51211
Author: poyaz <[email protected]>
Date:   Sat Mar 23 13:12:03 2024 +0330

    [FIX] Removing unnecessary snipped tag (tag: <SNIP>)

    Signed-off-by: poyaz <[email protected]>

commit 800b819
Author: poyaz <[email protected]>
Date:   Sat Mar 23 13:10:27 2024 +0330

    [UPDATE] Update operator and restic cli help according to new values is added

    Signed-off-by: poyaz <[email protected]>

commit 11f0945
Author: poyaz <[email protected]>
Date:   Sat Mar 23 13:09:48 2024 +0330

    [ADD] Adding RESTORE_CA_CERT_FILE, RESTORE_CA_CERT_FILE, RESTORE_CLIENT_KEY_FILE env instead of filling TLS and mTls options in restore method

    Signed-off-by: poyaz <[email protected]>

commit a9cf8fd
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:08:07 2024 +0330

    [FIX] Fixning problem in attach mode when failer happend in pod

    Signed-off-by: poyaz <[email protected]>

commit 97e03e0
Merge: 5270d54 b16b4bf
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:06:15 2024 +0330

    Merge remote-tracking branch 'upstream/master' into feature/custom-tls

    Signed-off-by: poyaz <[email protected]>

commit 5270d54
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:05:02 2024 +0330

    [ADD] Adding new e2e test for supporting self-signed issuer

    This test contains below sections:
    - Testing backup API for TLS and mTLS mode
    - Testing restore API in pvc for TLS and mTLS mode
    - Testing restore API in S3 for TLS and mTLS mode
    - Testing archive API in S3 for TLS and mTLS mode
    - Testin check API for TLS and mTLS mode

    Signed-off-by: poyaz <[email protected]>

commit f391110
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:04:44 2024 +0330

    [ADD] Add some fucntions for checking e2e test

    These fucntions add:
    - Adding "mc" function for using minio client for using download files, remove buckets, get list of files
    - Adding "given_a_clean_archive" function for clear archive bucket
    - Adding "given_a_subject_dl" function for apply deployment for checking last backup when restore in S3
    - Adding "give_self_signed_issuer" function for create self-signed issuer
    - Adding "expect_dl_file_in_container" function for checking is last backup was uploaded in S3 is okay

    Also fix some bugs:
    - Fixing empty output when get last dump of snapshot - becuase of syncing and storing file in disk, fetching last dump is took and the output of "run restic dump latest" is empty
    - Adding sleep before running restic and mc

    Signed-off-by: poyaz <[email protected]>

commit 2af7fd6
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:04:23 2024 +0330

    [ADD] Adding new resource definitions for e2e test in TLS and mTls mode

    These definitions contain below:
    - Adding archive
    Adding restore
    Adding backup
    Adding nginx for use reverse proxy in TLS and mTls mode
    Adding cert-manager for genrate self-signed issuer

    Signed-off-by: poyaz <[email protected]>

commit a56d465
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:03:58 2024 +0330

    [UPDATE] Generating new crd according to adding VolumeMounts to BackendSpec and RestoreMethodSpec

    Signed-off-by: poyaz <[email protected]>

commit ece84c7
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:03:46 2024 +0330

    [UPDATE] Addin VolumeMounts to BackendSpec and RestoreMethod

    Change:
    - Removing VolumeMounts from S3Spec and RestServerSpec in BackendSpec. Adding to BackendSpec (File: v1/backend.go)
    - Adding VolumeMounts to RestoreMethod (File: v1/restore_types.go)

    Signed-off-by: poyaz <[email protected]>

commit c42e748
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:02:47 2024 +0330

    [UPDATE] Generating new crd according to adding VolumeMounts to BackendSpec and RestoreMethodSpec

    Also these changes appends:
    - Running linter
    - Fixing check null pointer error if BackendSpec or Volume of Spec is null
    - Fixing check add duplicate VolumeMount in archive and restore API
    - Refactoring setupArgs

    Signed-off-by: poyaz <[email protected]>

commit a0f78d7
Author: poyaz <[email protected]>
Date:   Sat Mar 23 02:01:14 2024 +0330

    [ADD] Adding container volumes when they are mounting

    Signed-off-by: poyaz <[email protected]>

commit b16b4bf
Merge: 99eef08 8da2222
Author: Kidswiss <[email protected]>
Date:   Wed Mar 20 14:14:09 2024 +0100

    Merge pull request k8up-io#948 from Stogas/master

    Add option to ignore PVCs without annotation

commit 8da2222
Author: Ovidijus Balkauskas <[email protected]>
Date:   Wed Mar 20 14:32:51 2024 +0200

    Fix chart tests for new envVar in 4.5.1, pt2

    Signed-off-by: Ovidijus Balkauskas <[email protected]>

commit 7d5365d
Author: Ovidijus Balkauskas <[email protected]>
Date:   Tue Mar 19 17:34:02 2024 +0200

    Fix chart tests for new envVar in 4.5.1

    Signed-off-by: Ovidijus Balkauskas <[email protected]>

commit 24e1796
Author: Ovidijus Balkauskas <[email protected]>
Date:   Tue Mar 19 17:33:37 2024 +0200

    Generate chart docs for 4.5.1

    Signed-off-by: Ovidijus Balkauskas <[email protected]>

commit 2a55dbf
Author: Ovidijus Balkauskas <[email protected]>
Date:   Tue Mar 19 15:43:04 2024 +0200

    Add option to ignore PVCs without annotation

    Signed-off-by: Ovidijus Balkauskas <[email protected]>

commit 99eef08
Merge: 02185ae 772b97c
Author: Kidswiss <[email protected]>
Date:   Tue Mar 19 09:50:25 2024 +0100

    Merge pull request k8up-io#947 from k8up-io/bump/chart

    Bump chart version

commit 772b97c
Author: Simon Beck <[email protected]>
Date:   Tue Mar 19 09:16:22 2024 +0100

    Bump chart version

    Signed-off-by: Simon Beck <[email protected]>

commit 02185ae
Merge: cd6ceb5 60feb80
Author: Kidswiss <[email protected]>
Date:   Tue Mar 19 09:09:25 2024 +0100

    Merge pull request k8up-io#944 from k8up-io/optimize/e2e

    Replace unrealiable kubectl run --attach

commit 60feb80
Author: Simon Beck <[email protected]>
Date:   Tue Mar 19 08:36:25 2024 +0100

    Make e2e tests more reliable

    `kubectl run --attach` proved to be rather unreliable. It often was not
    able to attach to the newly created pod. There were various different
    error messages.

    By running the pod, waiting and then printing the logs, it improved the
    reliability by a lot. Where it previously failed ever so often, I was
    not able to have it fail once with the new function so far.

    Signed-off-by: Simon Beck <[email protected]>

commit e2622c6
Author: Pooya Azarpour <[email protected]>
Date:   Mon Mar 18 19:45:22 2024 +0330

    [ADD] Supporting self certificate authority and mTls when using S3 object storage

    Signed-off-by: Pooya Azarpour <[email protected]>

commit e13ba45
Author: Pooya Azarpour <[email protected]>
Date:   Mon Mar 18 19:43:39 2024 +0330

    [ADD] Add vardir command option for mount emptyDir in pod

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 8eb0703
Author: Pooya Azarpour <[email protected]>
Date:   Mon Mar 18 19:41:40 2024 +0330

    [ADD] Add Volume for using secret or configmap in k8s, Add VolumeMounts for mount volume, Add BackendOpts for using custom options in k8up or restic

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 2ea688a
Author: Pooya Azarpour <[email protected]>
Date:   Mon Mar 18 19:39:05 2024 +0330

    [ADD] Add GO_EXEC variable for using multiply version of go binary

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 43f750c
Author: Pooya Azarpour <[email protected]>
Date:   Mon Mar 18 19:37:59 2024 +0330

    [ADD] Ignoring vagrant dir in git

    Signed-off-by: Pooya Azarpour <[email protected]>

commit cd6ceb5
Author: Simon Beck <[email protected]>
Date:   Mon Mar 18 15:10:07 2024 +0100

    Fix scorecard action version

commit a76028a
Merge: 94da3f0 68cca92
Author: Kidswiss <[email protected]>
Date:   Mon Mar 18 14:24:12 2024 +0100

    Merge pull request k8up-io#937 from k8up-io/update/deps

    Update all renovate dependencies

commit 68cca92
Author: Simon Beck <[email protected]>
Date:   Fri Mar 15 14:50:31 2024 +0100

    Add debug info to e2e tests

    Signed-off-by: Simon Beck <[email protected]>

commit 26f2125
Author: Simon Beck <[email protected]>
Date:   Fri Mar 15 14:35:55 2024 +0100

    Fix chart go.mod

    Signed-off-by: Simon Beck <[email protected]>

commit 02752b7
Author: Simon Beck <[email protected]>
Date:   Fri Mar 15 13:28:43 2024 +0100

    Update kind

    Signed-off-by: Simon Beck <[email protected]>

commit 220a8b7
Author: Simon Beck <[email protected]>
Date:   Fri Mar 15 11:49:28 2024 +0100

    Update all renovate dependencies

    Signed-off-by: Simon Beck <[email protected]>

commit 94da3f0
Merge: b9cd317 e2eda7f
Author: Kidswiss <[email protected]>
Date:   Mon Mar 11 15:23:21 2024 +0100

    Merge pull request k8up-io#930 from k8up-io/fix/e2e-tests

    Update dependencies and e2e tests

commit b9cd317
Merge: 4e8a420 dd64772
Author: Kidswiss <[email protected]>
Date:   Thu Mar 7 10:10:02 2024 +0100

    Merge pull request k8up-io#927 from JcGKitten/master

    BUG: Set rest server credentials in repository URL

commit e2eda7f
Author: Simon Beck <[email protected]>
Date:   Thu Mar 7 10:04:28 2024 +0100

    Increase the timeout for the restic command

    Signed-off-by: Simon Beck <[email protected]>

commit 8ae0017
Author: Simon Beck <[email protected]>
Date:   Thu Mar 7 09:52:55 2024 +0100

    Update dependencies

    Signed-off-by: Simon Beck <[email protected]>

commit a9e3dc6
Author: Simon Beck <[email protected]>
Date:   Thu Mar 7 09:02:32 2024 +0100

    Fix deprecations

    Signed-off-by: Simon Beck <[email protected]>

commit 5a5b511
Author: Simon Beck <[email protected]>
Date:   Wed Mar 6 15:22:53 2024 +0100

    Go 1.21 fixes for e2e tests

    - Updated some dependencies so they work with 1.21
    - Changed the minio helm chart, as the old one wasn't available anymore
    - Changed the installation of the CRDs in the e2e test to a server-side
      apply, because they had a too large annotation otherwise

    Signed-off-by: Simon Beck <[email protected]>

commit dd64772
Author: Maxmilian Bertsch <[email protected]>
Date:   Tue Feb 27 14:22:54 2024 +0100

    ensure that REPOSITORY env var is set after credentials

    Signed-off-by: Maxmilian Bertsch <[email protected]>

commit 4e8a420
Merge: faf3001 983b418
Author: Kidswiss <[email protected]>
Date:   Mon Mar 4 16:47:45 2024 +0100

    Merge pull request k8up-io#928 from k8up-io/community-update-2

    add link to google docs agenda for community meeting

commit 983b418
Author: Tobias Brunner <[email protected]>
Date:   Mon Mar 4 16:28:09 2024 +0100

    add link to google docs agenda for community meeting

    Signed-off-by: Tobias Brunner <[email protected]>

commit ff43386
Author: Maxmilian Bertsch <[email protected]>
Date:   Tue Feb 27 14:22:32 2024 +0100

    set credentials in rest server url

    Signed-off-by: Maxmilian Bertsch <[email protected]>

commit faf3001
Merge: 8978cb3 ed2371a
Author: Tobias Brunner <[email protected]>
Date:   Thu Feb 1 15:08:19 2024 +0100

    Merge pull request k8up-io#922 from k8up-io/community-update

    K8up community update

commit ed2371a
Author: Tobias Brunner <[email protected]>
Date:   Thu Feb 1 14:13:46 2024 +0100

    update governance documentation to the latest state

    Signed-off-by: Tobias Brunner <[email protected]>

commit a64e247
Author: Tobias Brunner <[email protected]>
Date:   Thu Feb 1 14:10:30 2024 +0100

    adopt the CNCF CoC

    Signed-off-by: Tobias Brunner <[email protected]>

commit b33bd7b
Author: Tobias Brunner <[email protected]>
Date:   Thu Feb 1 12:01:57 2024 +0100

    introduce monthly community meeting

    Signed-off-by: Tobias Brunner <[email protected]>

commit 6289155
Author: Tobias Brunner <[email protected]>
Date:   Thu Feb 1 11:22:30 2024 +0100

    clarify maintainers of the project

    Signed-off-by: Tobias Brunner <[email protected]>

commit f68055c
Author: Tobias Brunner <[email protected]>
Date:   Thu Feb 1 11:09:16 2024 +0100

    clearly state project maturity

    Signed-off-by: Tobias Brunner <[email protected]>

commit 167e873
Author: Tobias Brunner <[email protected]>
Date:   Thu Feb 1 10:52:03 2024 +0100

    document k8up slack channel

    Signed-off-by: Tobias Brunner <[email protected]>

commit 8978cb3
Merge: 608c1d1 665aad6
Author: Kidswiss <[email protected]>
Date:   Tue Dec 19 08:31:06 2023 +0100

    Merge pull request k8up-io#916 from l0wl3vel/azure-path

    Add option to use a custom path inside an Azure Blob Storage Container

commit 665aad6
Author: Benjamin Ritter <[email protected]>
Date:   Wed Dec 13 13:13:51 2023 +0100

    fix: Add Tests

    Signed-off-by: Benjamin Ritter <[email protected]>

commit a8b084e
Author: Benjamin Ritter <[email protected]>
Date:   Wed Dec 13 13:04:00 2023 +0100

    feat: Add optional path field for Azure backend

    Signed-off-by: Benjamin Ritter <[email protected]>

commit 608c1d1
Merge: edbcbce c5b730a
Author: Kidswiss <[email protected]>
Date:   Mon Dec 11 14:09:16 2023 +0100

    Merge pull request k8up-io#915 from poyaz/fix/kind-pod-backup-with-command

    Fix/kind pod backup with command

commit c5b730a
Author: Pooya Azarpour <[email protected]>
Date:   Mon Dec 11 13:38:06 2023 +0330

    [ADD] Add new e2e test for single pod backup command

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 7767f61
Author: Pooya Azarpour <[email protected]>
Date:   Mon Dec 11 13:37:02 2023 +0330

    [ADD] Add new fucntion for test pod annotation

    [FIX] Fix helm chart of minio (The address of helm.min.io changed to charts.min.io) and values of chart has been change

    Signed-off-by: Pooya Azarpour <[email protected]>

commit a91c902
Author: Pooya Azarpour <[email protected]>
Date:   Mon Dec 11 13:34:16 2023 +0330

    [BUG] Fix problem when make backup from pod (becuase when create pod kind, the pod don't have OwnerReferences)

    Signed-off-by: Pooya Azarpour <[email protected]>

commit edbcbce
Merge: c5f5b56 8a1708d
Author: Kidswiss <[email protected]>
Date:   Wed Nov 29 15:31:47 2023 +0100

    Merge pull request k8up-io#911 from poyaz/bug/fix-restore-single-file-backup-command

    Bug/fix restore single file backup command

commit 8a1708d
Author: Pooya Azarpour <[email protected]>
Date:   Wed Nov 29 15:28:05 2023 +0330

    [ADD] Add e2e test for backupcommand

    Signed-off-by: Pooya Azarpour <[email protected]>

commit c14e099
Author: Pooya Azarpour <[email protected]>
Date:   Wed Nov 29 15:26:27 2023 +0330

    [CHANGE] Better handling error for json unmarshal when check `isRestoreSingleFile`

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 31237e9
Author: Pooya Azarpour <[email protected]>
Date:   Sat Nov 25 14:45:42 2023 +0330

    [FIX] Fix restore single file snapshot (when using backupcomamnd annotation). Ref: k8up-io#803

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 4ff934e
Author: Pooya Azarpour <[email protected]>
Date:   Sat Nov 25 14:45:35 2023 +0330

    [FIX] Fix using in 'yq' command when yq not contain eval flag

    Signed-off-by: Pooya Azarpour <[email protected]>

commit 4417b96
Author: Pooya Azarpour <[email protected]>
Date:   Sat Nov 25 14:42:19 2023 +0330

    [ADD] Add root project tmp folder in gitignore

    Signed-off-by: Pooya Azarpour <[email protected]>

commit c5f5b56
Merge: 160e339 21609cc
Author: wejdross <[email protected]>
Date:   Fri Nov 10 13:05:20 2023 +0100

    Merge pull request k8up-io#903 from mhutter/fix/makefile-help

    Ignore commented-out targets in `make help`

commit 160e339
Merge: 95398eb 6a2f0d5
Author: Bigli <[email protected]>
Date:   Fri Nov 10 11:42:50 2023 +0100

    Merge pull request k8up-io#897 from k8up-io/renovate/github.com-go-logr-logr-1.x

    fix(deps): update module github.com/go-logr/logr to v1.3.0

commit 21609cc
Author: Manuel Hutter <[email protected]>
Date:   Fri Oct 27 10:08:30 2023 +0200

    chore: remove commented-out code

    ¯\_(ツ)_/¯

    Signed-off-by: Manuel Hutter <[email protected]>

commit 5b051f3
Author: Manuel Hutter <[email protected]>
Date:   Fri Oct 27 10:05:16 2023 +0200

    chore: Ignore commented-out targets in `make help`

    There's a target that is commented-out in `envtest/integration.mk` that
    still shows up in the output of `make help`.

    This commit filters out lines that start with a comment (`#`)

    Signed-off-by: Manuel Hutter <[email protected]>

commit 6a2f0d5
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Fri Oct 27 07:28:21 2023 +0000

    fix(deps): update module github.com/go-logr/logr to v1.3.0

    Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Signed-off-by: eunames <[email protected]>
@mhutter
Copy link
Contributor

mhutter commented Jul 31, 2024

From what I can see, metrics.grafanaDashboard.enable

  • is named differently than everything else (which is named enabled or create)
  • Is not actually checked for, the CM is created no matter its setting

@SchoolGuy SchoolGuy deleted the add-grafana-dashboard branch July 31, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants